fix(translate): no "use the Lotus desktop app" advice inside the desktop app (#349)

Where the on-device Translator/LanguageDetector APIs are missing,
Settings said to use Chrome/Edge "or the Lotus desktop app", but the
Linux and macOS apps (WebKit) lack them too, and showed the advice to
people already in the app. Word it by platform. (The per-message
Translate action was already hidden where unsupported.)

Fixes #349

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

src/app/features/room/message/ForwardMessageDialog.tsx

@@ -47,12 +47,8 @@ import {
   recentForwardTargetsAtom,
   addRecentForwardTarget,
 } from '../../../state/recentForwardTargets';
-import {
-  buildForwardContent,
-  buildPlaintextAttachmentContent,
-  forwardEncryptionWarning,
-} from './forwardContent';
-import { useLocalRoomNames, getLocalRoomName } from '../../../hooks/useRoomMeta';
+import { buildForwardContent, buildPlaintextAttachmentContent } from './forwardContent';
+import { useLocalRoomNames } from '../../../hooks/useRoomMeta';
 
 type RoomRowProps = {
   room: Room;
@@ -279,14 +275,6 @@ export function ForwardMessageDialog({ mEvent, onClose }: Props) {
   // Selection persists across query changes: a room selected then filtered out
   // of the rendered slice stays selected.
   const [selectedRoomIds, setSelectedRoomIds] = useState<Set<string>>(new Set());
-  const encryptionWarning = forwardEncryptionWarning(
-    !!mx.getRoom(mEvent.getRoomId() ?? '')?.hasEncryptionStateEvent(),
-    [...selectedRoomIds]
-      .map((id) => mx.getRoom(id))
-      .filter((r): r is Room => !!r && !r.hasEncryptionStateEvent())
-      // The name the user sees (their own "Rename for me" name, if set).
-      .map((r) => getLocalRoomName(mx, r.roomId) ?? r.name),
-  );
 
   const toggleRoom = useCallback((roomId: string) => {
     setSelectedRoomIds((prev) => {
@@ -602,13 +590,7 @@ export function ForwardMessageDialog({ mEvent, onClose }: Props) {
                   shrink="No"
                   direction="Column"
                   style={{ padding: `${config.space.S200} ${config.space.S400}` }}
-                  gap="200"
                 >
-                  {encryptionWarning && (
-                    <Text size="T200" role="note" style={{ color: color.Warning.Main }}>
-                      {encryptionWarning}
-                    </Text>
-                  )}
                   <Button
                     variant="Primary"
                     size="400"

src/app/features/room/message/forwardContent.test.ts

@@ -1,7 +1,7 @@
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import { MatrixClient, MatrixEvent } from 'matrix-js-sdk';
-import { buildForwardContent, forwardEncryptionWarning, getForwardedMeta } from './forwardContent';
+import { buildForwardContent, getForwardedMeta } from './forwardContent';
 
 // Pure content builder buildForwardContent: refuses undecryptable events, forwards
 // the latest edit (`m.new_content`), and strips reply fallbacks + `m.relates_to`.
@@ -171,16 +171,3 @@ test('getForwardedMeta rejects malformed metadata', () => {
   assert.equal(getForwardedMeta({ 'io.lotus.forwarded': { sender: 1 } }), undefined);
   assert.equal(getForwardedMeta({}), undefined);
 });
-
-test('forwardEncryptionWarning: only from an encrypted room into unencrypted ones (#330)', () => {
-  assert.equal(forwardEncryptionWarning(false, ['general']), undefined);
-  assert.equal(forwardEncryptionWarning(true, []), undefined);
-  assert.match(
-    forwardEncryptionWarning(true, ['general']) ?? '',
-    /^general isn't encrypted\..*that room, along with who originally wrote it\.$/,
-  );
-  assert.match(
-    forwardEncryptionWarning(true, ['a', 'b']) ?? '',
-    /^2 of the rooms you picked aren't encrypted\..*those rooms/,
-  );
-});

src/app/features/room/message/forwardContent.ts

@@ -122,23 +122,3 @@ export async function buildPlaintextAttachmentContent(
 
   return plainContent;
 }
-
-/**
- * [Gitea #330] The note shown when forwarding out of an encrypted room into
- * rooms that aren't: the text (and a re-uploaded attachment) becomes readable
- * by the server, and the original author is shown with it. Undefined when
- * there's nothing to warn about.
- */
-export function forwardEncryptionWarning(
-  sourceEncrypted: boolean,
-  unencryptedDestNames: string[],
-): string | undefined {
-  if (!sourceEncrypted || unencryptedDestNames.length === 0) return undefined;
-  const where =
-    unencryptedDestNames.length === 1
-      ? `${unencryptedDestNames[0]} isn't encrypted.`
-      : `${unencryptedDestNames.length} of the rooms you picked aren't encrypted.`;
-  return `${where} The forwarded message (and any attachment) will be readable by the server and everyone in ${
-    unencryptedDestNames.length === 1 ? 'that room' : 'those rooms'
-  }, along with who originally wrote it.`;
-}

src/app/features/settings/general/General.tsx

@@ -108,6 +108,7 @@ import {
   TRANSLATE_TARGET_LANGUAGES,
   normalizeLang,
   isSupportedTargetLang,
+  translationUnavailableText,
 } from '../../../utils/translation/langUtils';
 import { chromeTranslationEngine } from '../../../utils/translation/chromeEngine';
 import { SequenceCardStyle } from '../styles.css';
@@ -2760,7 +2761,7 @@ function Messages() {
           description={
             translationSupported
               ? 'Translate messages written in other languages into this one. Runs entirely on your device — message text never leaves your computer or touches a cloud service.'
-              : 'On-device translation isn’t available in this browser. Use a Chromium desktop browser (Chrome/Edge 138+) or the Lotus desktop app.'
+              : translationUnavailableText(isTauriEnv())
           }
           after={
             <SettingsSelect

src/app/utils/translation/langUtils.test.ts

@@ -1,6 +1,7 @@
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import {
+  translationUnavailableText,
   normalizeLang,
   sameLanguage,
   languageName,
@@ -53,3 +54,9 @@ test('curated list: unique codes, English present', () => {
   assert.equal(new Set(codes).size, codes.length);
   assert.ok(codes.includes('en'));
 });
+
+test('translationUnavailableText: no "use the desktop app" inside the desktop app (#349)', () => {
+  assert.doesNotMatch(translationUnavailableText(true), /desktop app\.$|Lotus desktop app/);
+  assert.match(translationUnavailableText(true), /this version of the desktop app/);
+  assert.match(translationUnavailableText(false), /this browser/);
+});

src/app/utils/translation/langUtils.ts

@@ -85,3 +85,13 @@ export function languageName(code: string, uiLocale = 'en'): string {
 export function isSupportedTargetLang(code: string): boolean {
   return CURATED_NAME.has(normalizeLang(code));
 }
+
+/**
+ * [Gitea #349] Why translation is unavailable, by platform. The desktop app
+ * on Linux/macOS (WebKit) lacks the on-device APIs too, so it must not send
+ * people to "the Lotus desktop app" they're already using.
+ */
+export const translationUnavailableText = (desktopApp: boolean): string =>
+  desktopApp
+    ? 'On-device translation isn’t available in this version of the desktop app. It works in Chrome or Edge 138+ on a computer.'
+    : 'On-device translation isn’t available in this browser. Use Chrome or Edge 138+ on a computer.';