fix(settings): desktop-only settings get their own Desktop section (#290) #411

Merged
jared merged 1 commits from fix/desktop-settings-section into lotus 2026-10-18 10:18:10 -04:00
Owner

Fixes #290.

In the desktop app, Settings → General → Appearance contained Custom Window Chrome, Launch on login / When I close the window, and Login in the system keychain. They sat between Monochrome Mode and Twitter Emoji.

Change: a new Desktop section, placed just above App Updates, holding those settings. It renders nothing outside the desktop app (isTauri()). The settings themselves are unchanged.

Verified in Chromium with a stubbed __TAURI_INTERNALS__ bridge (screenshot below): the Desktop section shows Launch on login, the keychain status and Custom Window Chrome, and none of them sits inside Appearance any more. On the plain web build nothing changes.

tsc clean · ESLint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #290. In the desktop app, Settings → General → **Appearance** contained Custom Window Chrome, Launch on login / When I close the window, and Login in the system keychain. They sat between Monochrome Mode and Twitter Emoji. **Change:** a new **Desktop** section, placed just above App Updates, holding those settings. It renders nothing outside the desktop app (`isTauri()`). The settings themselves are unchanged. **Verified** in Chromium with a stubbed `__TAURI_INTERNALS__` bridge (screenshot below): the Desktop section shows Launch on login, the keychain status and Custom Window Chrome, and none of them sits inside Appearance any more. On the plain web build nothing changes. `tsc` clean · ESLint clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-18 00:28:18 -04:00
fix(settings): desktop-only settings get their own Desktop section (#290)
CI / Build & Quality Checks (pull_request) Successful in 2m50s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 19s
CI / Playwright smoke (e2e) (pull_request) Successful in 18m11s
86b77ac9f3
Custom Window Chrome, Launch on login / When I close the window and the
keychain status sat inside Appearance, between Monochrome Mode and
Twitter Emoji. Move them to a Desktop section (above App Updates),
rendered only in the desktop app.

Fixes #290

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Author
Owner

desktop section

![desktop section](https://code.lotusguild.org/attachments/24d59d73-77e9-469a-89c0-4e1e46cbed8a)
jared merged commit 3845d2e4a8 into lotus 2026-10-18 10:18:10 -04:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#411