fix(settings): valid HTML in setting tiles; start uploads in an effect (#291) #402

Merged

jared merged 1 commits from fix/settingtile-nesting into lotus

2026-10-18 05:37:07 -04:00

Author	SHA1	Message	Date
Lotus CIandClaude Opus 5.5	6f7a8f64e2	fix(settings): valid HTML in setting tiles; start uploads in an effect (#291 ) CI / Build & Quality Checks (pull_request) Successful in 4m24s Details CI / Trigger Desktop Build (pull_request) Skipped Details CI / Docker image build & smoke test (pull_request) Skipped Details CI / Secret scan (gitleaks) (pull_request) Successful in 11s Details CI / Playwright smoke (e2e) (pull_request) Successful in 15m43s Details SettingTile rendered its description in a <p>, and many tiles pass blocks (badges, Box, Text), so Settings had <div>/<p> inside <p> and React warned on every page. Render it as a <div>. UploadCardRenderer called startUpload() during render, which now updates the desktop taskbar-progress hook mid-render; start it from an effect instead. Refs #291 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5	2026-10-17 23:51:19 -04:00