Refs #291. This fixes the nesting and the render-time upload start. The "key" prop is being spread into JSX warning (Jump to Time, Invite) comes from a shared component and stays open.
Changes
SettingTile: the description now renders as <Text as="div">. Many tiles pass blocks as the description (badges, <Box>, <Text>), which made <div>/<p> inside <p>, invalid HTML that React warned about on every Settings page. One change fixes every tile, including Room Settings → Call Permissions / Quality.
UploadCardRenderer:startUpload() moves from render into a useEffect. Since the desktop taskbar-progress hook subscribes to the upload atoms, the render-time start updated another component mid-render ("Cannot update a component (TauriDesktopFeatures) while rendering…"). startUpload is a stable useCallback and the effect is guarded by the Idle status, so it starts once.
Verified with a DOM scan for p div, p p on each Settings page:
Before: General 8, Account 4, Notifications 0, Devices 0.
Refs #291. This fixes the nesting and the render-time upload start. The `"key" prop is being spread into JSX` warning (Jump to Time, Invite) comes from a shared component and stays open.
**Changes**
- **SettingTile:** the description now renders as `<Text as="div">`. Many tiles pass blocks as the description (badges, `<Box>`, `<Text>`), which made `<div>`/`<p>` inside `<p>`, invalid HTML that React warned about on every Settings page. One change fixes every tile, including Room Settings → Call Permissions / Quality.
- **UploadCardRenderer:** `startUpload()` moves from render into a `useEffect`. Since the desktop taskbar-progress hook subscribes to the upload atoms, the render-time start updated another component mid-render ("Cannot update a component (TauriDesktopFeatures) while rendering…"). `startUpload` is a stable `useCallback` and the effect is guarded by the Idle status, so it starts once.
**Verified** with a DOM scan for `p div, p p` on each Settings page:
- **Before:** General 8, Account 4, Notifications 0, Devices 0.
- **After:** **0 on every page**.
`tsc` clean · unit tests pass · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
SettingTile rendered its description in a <p>, and many tiles pass
blocks (badges, Box, Text), so Settings had <div>/<p> inside <p> and
React warned on every page. Render it as a <div>. UploadCardRenderer
called startUpload() during render, which now updates the desktop
taskbar-progress hook mid-render; start it from an effect instead.
Refs #291
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Refs #291. This fixes the nesting and the render-time upload start. The
"key" prop is being spread into JSXwarning (Jump to Time, Invite) comes from a shared component and stays open.Changes
<Text as="div">. Many tiles pass blocks as the description (badges,<Box>,<Text>), which made<div>/<p>inside<p>, invalid HTML that React warned about on every Settings page. One change fixes every tile, including Room Settings → Call Permissions / Quality.startUpload()moves from render into auseEffect. Since the desktop taskbar-progress hook subscribes to the upload atoms, the render-time start updated another component mid-render ("Cannot update a component (TauriDesktopFeatures) while rendering…").startUploadis a stableuseCallbackand the effect is guarded by the Idle status, so it starts once.Verified with a DOM scan for
p div, p pon each Settings page:tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5