When a room admin turns off Allow Screen Sharing mid-share, the sharer got two toasts:
"Screen sharing was turned off by a room admin." (useCallPolicyRevokedToast): correct.
"Screen sharing stopped — the shared window was closed." (the fork's io.lotus.screenshare_notice {kind: "ended"}): wrong.
Change:useScreenshareNotices skips the ended notice while the room policy forbids screen sharing (useRoomCallPolicy). It's read through a ref, so it doesn't matter which message arrives first. Other notice kinds (no-frames, alone) are unchanged.
Verified (in a call in the Voice Lounge: set io.lotus.room_quality.allow_screenshare = false, then had the call frame send the fork's ended notice):
Fixes #297.
When a room admin turns off **Allow Screen Sharing** mid-share, the sharer got two toasts:
1. "Screen sharing was turned off by a room admin." (`useCallPolicyRevokedToast`): correct.
2. "Screen sharing stopped — the shared window was closed." (the fork's `io.lotus.screenshare_notice {kind: "ended"}`): wrong.
**Change:** `useScreenshareNotices` skips the `ended` notice while the room policy forbids screen sharing (`useRoomCallPolicy`). It's read through a ref, so it doesn't matter which message arrives first. Other notice kinds (`no-frames`, `alone`) are unchanged.
**Verified** (in a call in the Voice Lounge: set `io.lotus.room_quality.allow_screenshare = false`, then had the call frame send the fork's `ended` notice):
- **Before:** the "window was closed" toast was shown.
- **After:** not shown.
Unit test for the rule. `tsc` clean · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
When a room admin turned off Allow Screen Sharing, the sharer got two
toasts: the correct "turned off by a room admin" and the fork's
"ended" notice, "the shared window was closed", which was wrong. Skip
the ended notice while the room policy forbids sharing.
Fixes#297
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #297.
When a room admin turns off Allow Screen Sharing mid-share, the sharer got two toasts:
useCallPolicyRevokedToast): correct.io.lotus.screenshare_notice {kind: "ended"}): wrong.Change:
useScreenshareNoticesskips theendednotice while the room policy forbids screen sharing (useRoomCallPolicy). It's read through a ref, so it doesn't matter which message arrives first. Other notice kinds (no-frames,alone) are unchanged.Verified (in a call in the Voice Lounge: set
io.lotus.room_quality.allow_screenshare = false, then had the call frame send the fork'sendednotice):Unit test for the rule.
tscclean · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5