LotusGuild/cinny
3
0
Fork 0
Code Issues 97 Pull Requests 18 Actions 17 Packages Projects Releases Wiki Activity

When a room admin turns off screen sharing, the sharer gets two contradictory toasts #297

New Issue
Open
opened 2026-10-04 21:03:51 -04:00 by jared · 1 comment
jared commented 2026-10-04 21:03:51 -04:00
Owner
Copy Link
Copy Source

What happens (two browsers, local LiveKit): Bob is sharing his screen; the room admin turns off Allow Screen Sharing. Bob's share stops correctly, and he gets two toasts at once (screenshot):

  1. "Screen share — Screen sharing stopped — the shared window was closed." This is the fork's io.lotus.screenshare_notice {kind:"ended"}, shown by useScreenshareNotices.
  2. "Screen sharing was turned off by a room admin." This one comes from useCallPolicyRevokedToast (#223).

The first is wrong: no window was closed.

Fix: when the host stops the share because of the policy, suppress the fork's ended notice that follows within a few seconds. Alternatively, have the fork tell a host-requested stop (io.lotus.set_screenshare {on:false}) apart from the track ending on its own, and send ended only for the latter (element-call src/lotus/lotusScreenshareWatch.ts).

Screenshot

F47-double-toast.png

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

**What happens** (two browsers, local LiveKit): Bob is sharing his screen; the room admin turns off **Allow Screen Sharing**. Bob's share stops correctly, and he gets **two** toasts at once (screenshot): 1. "Screen share — Screen sharing stopped — **the shared window was closed.**" This is the fork's `io.lotus.screenshare_notice {kind:"ended"}`, shown by `useScreenshareNotices`. 2. "Screen sharing was turned off by a room admin." This one comes from `useCallPolicyRevokedToast` (#223). The first is wrong: no window was closed. **Fix:** when the host stops the share because of the policy, suppress the fork's `ended` notice that follows within a few seconds. Alternatively, have the fork tell a host-requested stop (`io.lotus.set_screenshare {on:false}`) apart from the track ending on its own, and send `ended` only for the latter (element-call `src/lotus/lotusScreenshareWatch.ts`). **Screenshot** ![F47-double-toast.png](https://code.lotusguild.org/attachments/f31b572d-d397-4a12-9750-9919bd548150) --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
F47-double-toast.png
57 KiB
jared added the priority: lowuxarea: calls labels 2026-10-04 21:03:51 -04:00
jared commented 2026-10-05 23:56:14 -04:00
Author
Owner
Copy Link
Copy Source

Same double-toast when the share ends outside the app (the shared window closes, or the browser's own "Stop sharing" bar is used; simulated by ending the display track in the frame). Lotus shows both "You stopped sharing your screen" and the fork's screenshare_notice toast "Screen sharing stopped — the shared window was closed." The first is wrong in this case, since the user didn't stop it. Suppress the generic "You stopped sharing" when a screenshare_notice with kind: ended arrives within ~2 s, as suggested for the policy case.

Same double-toast when the share ends **outside** the app (the shared window closes, or the browser's own "Stop sharing" bar is used; simulated by ending the display track in the frame). Lotus shows both **"You stopped sharing your screen"** and the fork's `screenshare_notice` toast **"Screen sharing stopped — the shared window was closed."** The first is wrong in this case, since the user didn't stop it. Suppress the generic "You stopped sharing" when a `screenshare_notice` with `kind: ended` arrives within ~2 s, as suggested for the policy case.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: calls priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#297