dedupePolicyEntries keyed on `${entity} ${recommendation}` using the raw recommendation. A bot's stable rule (m.ban) and its legacy twin (org.matrix.mjolnir.ban) for the same entity therefore never matched, and the viewer listed the rule twice, both labelled "Ban".
Change
New normalizeRecommendation (org.matrix.mjolnir.ban → m.ban), used both for the de-dup key and for recommendationLabel.
The pure helpers (PolicyEntry, recommendationLabel, dedupePolicyEntries) move to policyEntries.ts so they can be unit-tested. The viewer's rendering is unchanged.
Tests: the issue's exact case, @spammer:evil.example under both m.ban and org.matrix.mjolnir.ban plus a glob rule, now gives 2 entries instead of 3. Different recommendations for one entity stay separate, and there are label cases. No UI run: this is a pure keying change covered by the unit test.
Fixes #321.
`dedupePolicyEntries` keyed on `` `${entity} ${recommendation}` `` using the **raw** recommendation. A bot's stable rule (`m.ban`) and its legacy twin (`org.matrix.mjolnir.ban`) for the same entity therefore never matched, and the viewer listed the rule twice, both labelled "Ban".
**Change**
- New `normalizeRecommendation` (`org.matrix.mjolnir.ban` → `m.ban`), used both for the de-dup key and for `recommendationLabel`.
- The pure helpers (`PolicyEntry`, `recommendationLabel`, `dedupePolicyEntries`) move to `policyEntries.ts` so they can be unit-tested. The viewer's rendering is unchanged.
**Tests:** the issue's exact case, `@spammer:evil.example` under both `m.ban` and `org.matrix.mjolnir.ban` plus a glob rule, now gives 2 entries instead of 3. Different recommendations for one entity stay separate, and there are label cases. No UI run: this is a pure keying change covered by the unit test.
`tsc` clean · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
dedupePolicyEntries keyed on the raw recommendation, so m.ban and
org.matrix.mjolnir.ban for the same entity never matched and the rule
showed twice (both labelled "Ban"). Key on the normalised value; move
the pure helpers to policyEntries.ts with unit tests.
Fixes#321
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #321.
dedupePolicyEntrieskeyed on`${entity} ${recommendation}`using the raw recommendation. A bot's stable rule (m.ban) and its legacy twin (org.matrix.mjolnir.ban) for the same entity therefore never matched, and the viewer listed the rule twice, both labelled "Ban".Change
normalizeRecommendation(org.matrix.mjolnir.ban→m.ban), used both for the de-dup key and forrecommendationLabel.PolicyEntry,recommendationLabel,dedupePolicyEntries) move topolicyEntries.tsso they can be unit-tested. The viewer's rendering is unchanged.Tests: the issue's exact case,
@spammer:evil.exampleunder bothm.banandorg.matrix.mjolnir.banplus a glob rule, now gives 2 entries instead of 3. Different recommendations for one entity stay separate, and there are label cases. No UI run: this is a pure keying change covered by the unit test.tscclean · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5