SecurityBanner hides itself while another status strip is showing. It checked this by calling pickBannerwithout the dismissed set that ServerStatusBanner uses. So an announcement the user had already dismissed still counted as "another strip", and the verify / connect-backup / set-up-backup nudge stayed hidden for as long as the announcement was posted, often weeks.
Change
The dismissed set moves into a shared jotai atom, statusDismissedAtom in state/serverStatus.ts. It's still persisted to lotus-status-banner-dismissed, and is session-only if storage is unavailable.
ServerStatusBanner writes to it, and SecurityBanner passes it to pickBanner. A dismiss updates both straight away.
Verified: new Playwright test in e2e/security-nudge.spec.ts. Kuma is served a fixture with "Community call on Friday", and the device is past its grace period.
The announcement shows and the nudge doesn't.
Dismiss the announcement, then reload.
The nudge shows: "Your encryption keys aren't backed up".
The test fails with the old behaviour and passes here.
Fixes #307.
`SecurityBanner` hides itself while another status strip is showing. It checked this by calling `pickBanner` **without** the dismissed set that `ServerStatusBanner` uses. So an announcement the user had already dismissed still counted as "another strip", and the verify / connect-backup / set-up-backup nudge stayed hidden for as long as the announcement was posted, often weeks.
**Change**
- The dismissed set moves into a shared jotai atom, `statusDismissedAtom` in `state/serverStatus.ts`. It's still persisted to `lotus-status-banner-dismissed`, and is session-only if storage is unavailable.
- `ServerStatusBanner` writes to it, and `SecurityBanner` passes it to `pickBanner`. A dismiss updates both straight away.
**Verified:** new Playwright test in `e2e/security-nudge.spec.ts`. Kuma is served a fixture with "Community call on Friday", and the device is past its grace period.
1. The announcement shows and the nudge doesn't.
2. Dismiss the announcement, then reload.
3. The nudge shows: "Your encryption keys aren't backed up".
The test **fails with the old behaviour** and **passes here**.
`tsc` clean · unit tests pass · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
SecurityBanner asked pickBanner whether another strip would show without
the dismissed set, so a dismissed Kuma announcement (often pinned for
weeks) still counted and suppressed the verify / backup nudge on every
device that had dismissed it. The dismissed set is now a shared jotai
atom (still persisted to localStorage) used by both banners. Adds a
Playwright regression.
Fixes#307
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #307.
SecurityBannerhides itself while another status strip is showing. It checked this by callingpickBannerwithout the dismissed set thatServerStatusBanneruses. So an announcement the user had already dismissed still counted as "another strip", and the verify / connect-backup / set-up-backup nudge stayed hidden for as long as the announcement was posted, often weeks.Change
statusDismissedAtominstate/serverStatus.ts. It's still persisted tolotus-status-banner-dismissed, and is session-only if storage is unavailable.ServerStatusBannerwrites to it, andSecurityBannerpasses it topickBanner. A dismiss updates both straight away.Verified: new Playwright test in
e2e/security-nudge.spec.ts. Kuma is served a fixture with "Community call on Friday", and the device is past its grace period.The test fails with the old behaviour and passes here.
tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5