LotusGuild/cinny
3
0
Fork 0
Code Issues 40 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Security nudge never shows while a dismissed Kuma announcement is still posted #307

New Issue
Closed
opened 2026-10-04 23:53:35 -04:00 by jared · 0 comments
jared commented 2026-10-04 23:53:35 -04:00
Owner
Copy Link
Copy Source

SecurityBanner stays hidden whenever a status strip would be showing (src/app/features/security-nudge/SecurityBanner.tsx):

const otherStrip = syncLost || !!pickBanner(serverStatus, { syncLost, where: 'client' });

It calls pickBanner without the dismissed set that ServerStatusBanner passes. An announcement the user has already dismissed therefore still counts as "another strip". Nothing is on screen, and the nudge is suppressed anyway.

Repro (Playwright; aud_bob has no key backup; the nudge record was aged past the 24 h grace period; Kuma routed to a fixture):

  1. With no Kuma announcement, the "Your encryption keys aren't backed up… Set up" strip appears about 23 s after load, as designed.
  2. Post an announcement ("Community call on Friday") on the status page, reload, and dismiss it.
  3. Reload. No strip shows within 75 s, and none will for as long as the announcement stays posted.

Kuma announcements are pinned and often stay up for days or weeks. While one is up, every device that dismissed it never gets the verify-device / connect-backup / setup-backup nudge, which is the one that protects against losing encrypted history. A dismissed "Voice calls are down" strip does the same for the length of an outage.

Fix: pass the same dismissed set (readDismissed() from ServerStatusBanner.tsx, ideally held in shared state so a dismiss updates both), or have ServerStatusBanner publish the banner it actually shows. Unit test: dismissed announcement + setup-backup state → the nudge shows.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

`SecurityBanner` stays hidden whenever a status strip would be showing (`src/app/features/security-nudge/SecurityBanner.tsx`): ```ts const otherStrip = syncLost || !!pickBanner(serverStatus, { syncLost, where: 'client' }); ``` It calls `pickBanner` **without** the `dismissed` set that `ServerStatusBanner` passes. An announcement the user has already dismissed therefore still counts as "another strip". Nothing is on screen, and the nudge is suppressed anyway. **Repro** (Playwright; aud_bob has no key backup; the nudge record was aged past the 24 h grace period; Kuma routed to a fixture): 1. With no Kuma announcement, the "Your encryption keys aren't backed up… Set up" strip appears about 23 s after load, as designed. 2. Post an announcement ("Community call on Friday") on the status page, reload, and dismiss it. 3. Reload. No strip shows within 75 s, and none will for as long as the announcement stays posted. Kuma announcements are pinned and often stay up for days or weeks. While one is up, every device that dismissed it never gets the verify-device / connect-backup / setup-backup nudge, which is the one that protects against losing encrypted history. A dismissed "Voice calls are down" strip does the same for the length of an outage. **Fix:** pass the same dismissed set (`readDismissed()` from `ServerStatusBanner.tsx`, ideally held in shared state so a dismiss updates both), or have `ServerStatusBanner` publish the banner it actually shows. Unit test: dismissed announcement + `setup-backup` state → the nudge shows. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: lowarea: settings labels 2026-10-04 23:53:35 -04:00
jared closed this issue 2026-10-18 01:49:48 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: settings bug priority: low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#307