The emoji/sticker board opens with focus in its Search field. Its FocusTrap used the shared stopPropagation helper as escapeDeactivates, and that helper returns false while an input is focused. So Escape never closed the board, in any browser.
Change: this trap always closes on Escape. It still calls stopPropagation(), so the key doesn't also close the room or a modal underneath. The GIF picker uses focus-trap's default and already closed on Escape.
Fixes #304.
The emoji/sticker board opens with focus in its **Search** field. Its FocusTrap used the shared `stopPropagation` helper as `escapeDeactivates`, and that helper returns `false` while an input is focused. So Escape never closed the board, in any browser.
**Change:** this trap always closes on Escape. It still calls `stopPropagation()`, so the key doesn't also close the room or a modal underneath. The GIF picker uses focus-trap's default and already closed on Escape.
**Verified** (Chromium, composer in a room):
- **Before:** Insert emoji: focus = Search input, `openAfterEscape=true`. Insert sticker: the same.
- **After:** emoji `openAfterEscape=false`, sticker `openAfterEscape=false`, and the room stays open.
`tsc` clean · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
The board opens with focus in its search field, and its FocusTrap used
the shared stopPropagation helper, which ignores Escape while an input
is focused, so Escape never closed it (Chromium, Firefox, WebKit).
Always close on Escape here, still stopping the key from closing the
room or modal underneath. The GIF picker already uses the default.
Fixes#304
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #304.
The emoji/sticker board opens with focus in its Search field. Its FocusTrap used the shared
stopPropagationhelper asescapeDeactivates, and that helper returnsfalsewhile an input is focused. So Escape never closed the board, in any browser.Change: this trap always closes on Escape. It still calls
stopPropagation(), so the key doesn't also close the room or a modal underneath. The GIF picker uses focus-trap's default and already closed on Escape.Verified (Chromium, composer in a room):
openAfterEscape=true. Insert sticker: the same.openAfterEscape=false, stickeropenAfterEscape=false, and the room stays open.tscclean · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5