LotusGuild/cinny
3
0
Fork 0
Code Issues 39 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Escape doesn't close the composer's emoji/sticker board in any browser (focus starts in its search field) #304

New Issue
Closed
opened 2026-10-04 21:36:12 -04:00 by jared · 0 comments
jared commented 2026-10-04 21:36:12 -04:00
Owner
Copy Link
Copy Source

Opening the composer's emoji board puts focus in its Search field, and Escape doesn't close the board. Only a click outside does. Verified in Chromium, Firefox and WebKit (Playwright): focus=INPUT Search, openAfterEscape=true, openAfterOutsideClick=false.

Why: EmojiBoard's FocusTrap uses escapeDeactivates: stopPropagation (src/app/components/emoji-board/EmojiBoard.tsx:615). stopPropagation (src/app/utils/keyboard.ts:36) returns false whenever focus is in an input, so Escape is ignored while focus is in the search field, which is exactly where the board puts it. This is upstream Cinny's code, unchanged, so it's probably an upstream behaviour that Lotus inherits.

Fix: let Escape close the board even from its search field, e.g. escapeDeactivates: () => true for this trap, or clear the query on the first Escape and close on the second. Then check the sticker and GIF boards, which share the component.

(First filed as Safari-only; the later Chromium and Firefox checks showed it happens everywhere.)

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

Opening the composer's emoji board puts focus in its **Search** field, and **Escape doesn't close the board**. Only a click outside does. Verified in **Chromium, Firefox and WebKit** (Playwright): `focus=INPUT Search`, `openAfterEscape=true`, `openAfterOutsideClick=false`. **Why:** `EmojiBoard`'s FocusTrap uses `escapeDeactivates: stopPropagation` (src/app/components/emoji-board/EmojiBoard.tsx:615). `stopPropagation` (src/app/utils/keyboard.ts:36) returns `false` whenever focus is in an input, so Escape is ignored while focus is in the search field, which is exactly where the board puts it. This is upstream Cinny's code, unchanged, so it's probably an upstream behaviour that Lotus inherits. **Fix:** let Escape close the board even from its search field, e.g. `escapeDeactivates: () => true` for this trap, or clear the query on the first Escape and close on the second. Then check the sticker and GIF boards, which share the component. (First filed as Safari-only; the later Chromium and Firefox checks showed it happens everywhere.) --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: lowarea: messaging labels 2026-10-04 21:36:12 -04:00
jared changed title from Safari/WebKit: Escape doesn't close the composer's emoji/sticker board to Escape doesn't close the composer's emoji/sticker board in any browser (focus starts in its search field) 2026-10-04 21:43:32 -04:00
jared closed this issue 2026-10-18 00:27:07 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging bug priority: low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#304