PollContent read mEvent.getId() once, during render. For a poll you've just created, that is the local-echo id (~!room:txn). Nothing re-rendered it when the SDK swapped in the real $id, which caused two failures:
The vote's m.relates_to pointed at the local id.
The SDK then threw synchronously (Cannot call getPendingEvents with pendingEventOrdering == chronological), so no vote was sent until a reload.
Change
The id is now state, updated on MatrixEventEvent.LocalEventIdReplaced and Status, so the vote, end-poll and tally all use the real id.
Voting and ending are disabled while the id is still local.
Synchronous throws from the send are caught.
Verified
New Playwright test in e2e/local-homeserver.spec.ts: create a poll in the UI, vote without reloading, and assert an m.poll.response relating to the real $ id. It fails on lotus and passes here.
Manual run: before, a page error and no vote reached the server. After, the vote arrived and there were no page errors.
Note: the timeline row's data-message-id still shows the local id until a reload. That is cosmetic and separate, so I left it alone.
Fixes #284.
`PollContent` read `mEvent.getId()` once, during render. For a poll you've just created, that is the local-echo id (`~!room:txn`). Nothing re-rendered it when the SDK swapped in the real `$id`, which caused two failures:
- The vote's `m.relates_to` pointed at the local id.
- The SDK then threw synchronously (`Cannot call getPendingEvents with pendingEventOrdering == chronological`), so no vote was sent until a reload.
**Change**
- The id is now state, updated on `MatrixEventEvent.LocalEventIdReplaced` and `Status`, so the vote, end-poll and tally all use the real id.
- Voting and ending are disabled while the id is still local.
- Synchronous throws from the send are caught.
**Verified**
- New Playwright test in `e2e/local-homeserver.spec.ts`: create a poll in the UI, vote without reloading, and assert an `m.poll.response` relating to the real `$` id. It **fails on `lotus`** and **passes here**.
- Manual run: before, a page error and no vote reached the server. After, the vote arrived and there were no page errors.
Note: the timeline row's `data-message-id` still shows the local id until a reload. That is cosmetic and separate, so I left it alone.
`tsc` clean · unit tests pass · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
PollContent read mEvent.getId() once at render. For your own new poll
that is the local echo id (~!room:txn), and nothing re-rendered it when
the SDK swapped in the real $id, so the vote related to the local id
and the SDK threw synchronously (getPendingEvents under chronological
ordering): no vote was ever sent. Track the id via LocalEventIdReplaced
and Status, block voting while it is still local, and catch synchronous
throws. Adds the Playwright regression the issue asks for.
Fixes#284
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #284.
PollContentreadmEvent.getId()once, during render. For a poll you've just created, that is the local-echo id (~!room:txn). Nothing re-rendered it when the SDK swapped in the real$id, which caused two failures:m.relates_topointed at the local id.Cannot call getPendingEvents with pendingEventOrdering == chronological), so no vote was sent until a reload.Change
MatrixEventEvent.LocalEventIdReplacedandStatus, so the vote, end-poll and tally all use the real id.Verified
e2e/local-homeserver.spec.ts: create a poll in the UI, vote without reloading, and assert anm.poll.responserelating to the real$id. It fails onlotusand passes here.Note: the timeline row's
data-message-idstill shows the local id until a reload. That is cosmetic and separate, so I left it alone.tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5