LotusGuild/cinny
3
0
Fork 0
Code Issues 113 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

You can't vote on a poll you just created (until a reload): the vote targets the poll's local-echo id and throws #284

New Issue
Open
opened 2026-10-04 19:50:21 -04:00 by jared · 0 comments
jared commented 2026-10-04 19:50:21 -04:00
Owner
Copy Link
Copy Source

What happens

  1. Create a poll in any room and wait (10 s is plenty).
  2. Click an answer.
  3. Nothing is recorded. The console shows an uncaught Error: Cannot call getPendingEvents with pendingEventOrdering == chronological, and no m.poll.response reaches the server.
  4. After a reload, voting works.

Others' votes do show up for the creator; "End poll" works too.

Why

  • PollContent reads const eventId = mEvent.getId() during render (src/app/components/message/content/PollContent.tsx:102). It is never re-rendered when the SDK swaps the local echo's ~!room:txn id for the real $event id, so the timeline row keeps the local id. Even data-message-id on your own new messages stays ~….
  • handleVote then sends m.relates_to.event_id: '~!…'. The SDK's sendCompleteEvent sees a relation to a pending event, calls room.getPendingEvents(), and that throws under Lotus's chronological ordering. The throw is synchronous, so .catch() doesn't catch it.

Introduced by 0b061584 (2026-07-09, poll lifecycle).

Fix

  • Read the id at click time (mEvent.getId() inside handleVote, or subscribe to MatrixEventEvent.LocalEventIdReplaced).
  • Disable voting while the poll is still pending (mEvent.status !== null).
  • Wrap the send in try/catch.

Worth auditing other handlers that capture mEvent.getId() at render for your own fresh messages. In this audit, reactions, reply-in-thread, pin, delete and edit all worked.

Acceptance criteria: a Playwright test that creates a poll, votes without reloading, and asserts an m.poll.response relating to the real $ id.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

**What happens** 1. Create a poll in any room and wait (10 s is plenty). 2. Click an answer. 3. Nothing is recorded. The console shows an uncaught `Error: Cannot call getPendingEvents with pendingEventOrdering == chronological`, and no `m.poll.response` reaches the server. 4. After a reload, voting works. Others' votes do show up for the creator; "End poll" works too. **Why** - `PollContent` reads `const eventId = mEvent.getId()` during render (src/app/components/message/content/PollContent.tsx:102). It is never re-rendered when the SDK swaps the local echo's `~!room:txn` id for the real `$event` id, so the timeline row keeps the local id. Even `data-message-id` on your own new messages stays `~…`. - `handleVote` then sends `m.relates_to.event_id: '~!…'`. The SDK's `sendCompleteEvent` sees a relation to a pending event, calls `room.getPendingEvents()`, and that throws under Lotus's `chronological` ordering. The throw is synchronous, so `.catch()` doesn't catch it. **Introduced by** 0b061584 (2026-07-09, poll lifecycle). **Fix** - Read the id at click time (`mEvent.getId()` inside `handleVote`, or subscribe to `MatrixEventEvent.LocalEventIdReplaced`). - Disable voting while the poll is still pending (`mEvent.status !== null`). - Wrap the send in try/catch. Worth auditing other handlers that capture `mEvent.getId()` at render for your own fresh messages. In this audit, reactions, reply-in-thread, pin, delete and edit all worked. **Acceptance criteria:** a Playwright test that creates a poll, votes without reloading, and asserts an `m.poll.response` relating to the real `$` id. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: mediumarea: messaging labels 2026-10-04 19:50:21 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging bug priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#284