useNotificationsQuiet evaluated the quiet-hours window, and the "Pause notifications" expiry, only at render time. The long-lived message and invite notifiers rarely re-render. So someone leaving Lotus open overnight with quiet hours 22:00–07:00 got every sound all night, and a 30-minute pause could outlast itself.
Change: the hook re-evaluates every 30 s, the same approach as the night-light overlay.
Verified headless (notifications granted, window unfocused), with quiet hours set to start about 75 s after the app opened:
A DM before the window notified.
A DM inside the window, with the app left alone: before the fix it still notified; now it's silent.
tsc clean · unit tests pass · ESLint/Prettier clean.
Fixes #325.
`useNotificationsQuiet` evaluated the quiet-hours window, and the "Pause notifications" expiry, **only at render time**. The long-lived message and invite notifiers rarely re-render. So someone leaving Lotus open overnight with quiet hours 22:00–07:00 got every sound all night, and a 30-minute pause could outlast itself.
**Change:** the hook re-evaluates every 30 s, the same approach as the night-light overlay.
**Verified** headless (notifications granted, window unfocused), with quiet hours set to start about 75 s after the app opened:
- A DM **before** the window notified.
- A DM **inside** the window, with the app left alone: before the fix it still notified; now it's silent.
`tsc` clean · unit tests pass · ESLint/Prettier clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
useNotificationsQuiet evaluated the quiet-hours window (and the
"Pause notifications" expiry) only at render time, and the long-lived
message/invite notifiers rarely re-render, so someone leaving Lotus open
overnight with quiet hours 22:00–07:00 got every sound all night (and a
30-minute pause could outlast itself). The hook now re-evaluates every
30 s.
Verified headless (notifications granted, window unfocused): quiet
hours set to start ~75 s after the app opened; a DM before the window
notified; one inside the window, with the app left alone: before it
still notified, now it's silent.
Fixes#325
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared
merged commit 1784d40ba1 into lotus2026-10-17 17:51:40 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #325.
useNotificationsQuietevaluated the quiet-hours window, and the "Pause notifications" expiry, only at render time. The long-lived message and invite notifiers rarely re-render. So someone leaving Lotus open overnight with quiet hours 22:00–07:00 got every sound all night, and a 30-minute pause could outlast itself.Change: the hook re-evaluates every 30 s, the same approach as the night-light overlay.
Verified headless (notifications granted, window unfocused), with quiet hours set to start about 75 s after the app opened:
tscclean · unit tests pass · ESLint/Prettier clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5