LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Quiet hours don't start (or end) while the app stays open: the window is only checked when the notifier happens to re-render #325

New Issue
Closed
opened 2026-10-05 18:03:58 -04:00 by jared · 1 comment
jared commented 2026-10-05 18:03:58 -04:00
Owner
Copy Link
Copy Source

useNotificationsQuiet() (src/app/hooks/useNotificationsQuiet.ts) evaluates isWithinTimeWindow(quietHoursStart, quietHoursEnd) at render time, with no clock tick. MessageNotifications and InviteNotifications (src/app/pages/client/ClientNonUIFeatures.tsx:232, 474) are long-lived listeners that rarely re-render, so their quietActive freezes at whatever it was at the last render. (The night-light overlay in App.tsx:145 has a 60 s forceTick for exactly this reason. The incoming-call ringtone is fine because its components mount fresh for each ring.)

Measured (headed Chromium so notification permission is really granted; page focused; Bob DMs while I'm in another room):

quiet hours 18:03–18:41 set at 18:02, then the app left alone
  18:02 (before window)                        → toast + sound   (expected)
  18:03:20 (inside window, app idle since 18:02) → toast + sound   ✗ quiet hours ignored
  after a reload, still inside the window      → nothing         (expected)

In practice someone who leaves Lotus open overnight with quiet hours 22:00–07:00 gets every message sound all night. In the morning the reverse can happen: still "quiet" until something re-renders.

Fix: give useNotificationsQuiet a minute tick (useState + setInterval(…, 60_000), like App.tsx's night light). Or, simpler for the listeners, call the pure isNotificationsQuiet({...now: new Date()}) inside deliverNotification / the invite handler at delivery time, reading the current settings from a ref. Add a unit test with fake timers that crosses the start boundary without re-rendering.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

`useNotificationsQuiet()` (src/app/hooks/useNotificationsQuiet.ts) evaluates `isWithinTimeWindow(quietHoursStart, quietHoursEnd)` **at render time**, with no clock tick. `MessageNotifications` and `InviteNotifications` (src/app/pages/client/ClientNonUIFeatures.tsx:232, 474) are long-lived listeners that rarely re-render, so their `quietActive` freezes at whatever it was at the last render. (The night-light overlay in `App.tsx:145` has a 60 s `forceTick` for exactly this reason. The incoming-call ringtone is fine because its components mount fresh for each ring.) **Measured** (headed Chromium so notification permission is really granted; page focused; Bob DMs while I'm in another room): ``` quiet hours 18:03–18:41 set at 18:02, then the app left alone 18:02 (before window) → toast + sound (expected) 18:03:20 (inside window, app idle since 18:02) → toast + sound ✗ quiet hours ignored after a reload, still inside the window → nothing (expected) ``` In practice someone who leaves Lotus open overnight with quiet hours 22:00–07:00 gets every message sound all night. In the morning the reverse can happen: still "quiet" until something re-renders. **Fix:** give `useNotificationsQuiet` a minute tick (`useState` + `setInterval(…, 60_000)`, like App.tsx's night light). Or, simpler for the listeners, call the pure `isNotificationsQuiet({...now: new Date()})` inside `deliverNotification` / the invite handler at delivery time, reading the current settings from a ref. Add a unit test with fake timers that crosses the start boundary without re-rendering. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: mediumarea: notifications labels 2026-10-05 18:03:58 -04:00
jared commented 2026-10-05 18:04:08 -04:00
Author
Owner
Copy Link
Copy Source

The same hook also evaluates isSnoozeActive(snoozeUntil) at render time. So Pause Notifications → 30 minutes likely has the mirror-image problem: when the 30 minutes are up, message and invite sounds/toasts stay suppressed until the notifier re-renders (a settings change, a room switch, etc.). This follows from the code; I didn't time it. The minute tick fixes both.

The same hook also evaluates `isSnoozeActive(snoozeUntil)` at render time. So **Pause Notifications → 30 minutes** likely has the mirror-image problem: when the 30 minutes are up, message and invite sounds/toasts stay suppressed until the notifier re-renders (a settings change, a room switch, etc.). This follows from the code; I didn't time it. The minute tick fixes both.
jared closed this issue 2026-10-17 17:51:40 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: notifications bug priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#325