fix(dialogs): Enter in Poll, Schedule, Report dialogs no longer discards input (#315) #369

Merged
jared merged 2 commits from fix/dialog-enter-closes into lotus 2026-10-17 18:35:55 -04:00
Owner

Fixes #315.

Several dialogs are <Box as="form">, with the header ✕ as the form's first button. That's a folds IconButton with no type, so it's a submit button. On implicit submission, pressing Enter in a text field "clicked" ✕, closing the dialog and throwing away what you'd typed: a poll's question and answers, a schedule, a report reason.

Change: the header close/cancel IconButtons now have type="button" in:

  • Create Poll, Schedule Message, Report User, Report Room;
  • the Account Data editor and State Event editor;
  • device verification setup;
  • the message delete and report dialogs.

Verified headless in Create Poll, typing a question and pressing Enter:

  • Before: the dialog closed and the question was lost.
  • After: it stays open with "Where should we eat?" kept.

tsc clean · unit tests pass · ESLint/Prettier clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #315. Several dialogs are `<Box as="form">`, with the header ✕ as the form's first button. That's a folds `IconButton` with no `type`, so it's a **submit** button. On implicit submission, pressing Enter in a text field "clicked" ✕, closing the dialog and throwing away what you'd typed: a poll's question and answers, a schedule, a report reason. **Change:** the header close/cancel `IconButton`s now have `type="button"` in: - Create Poll, Schedule Message, Report User, Report Room; - the Account Data editor and State Event editor; - device verification setup; - the message delete and report dialogs. **Verified** headless in Create Poll, typing a question and pressing Enter: - **Before:** the dialog closed and the question was lost. - **After:** it stays open with "Where should we eat?" kept. `tsc` clean · unit tests pass · ESLint/Prettier clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-16 21:58:11 -04:00
fix(dialogs): Enter in Poll, Schedule, Report dialogs no longer discards input (#315)
CI / Build & Quality Checks (pull_request) Successful in 3m58s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 11s
CI / Playwright smoke (e2e) (pull_request) Failing after 18m27s
b6f9af3f58
Several dialogs are <Box as="form"> with the header ✕ (folds IconButton,
no type attribute, so a submit button) as the form's first button. On
implicit submission, Enter in a text field "clicked" ✕, closing the dialog
and throwing away what was typed (a poll's question and answers, a
schedule, a report reason).

The header close/cancel IconButtons now have type="button": Create Poll,
Schedule Message, Report User, Report Room, Account Data editor, State
Event editor, device verification setup, and the message delete/report
dialogs.

Verified headless: in Create Poll, typing a question and pressing Enter
used to close the dialog; now it stays open with the question kept.

Fixes #315

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-17 17:53:09 -04:00
Merge branch 'lotus' into fix/dialog-enter-closes
CI / Build & Quality Checks (pull_request) Successful in 3m12s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 14s
CI / Playwright smoke (e2e) (pull_request) Successful in 13m57s
f0b7400d1b
jared merged commit f84c0d6e9e into lotus 2026-10-17 18:35:55 -04:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#369