LotusGuild/cinny
3
0
Fork 0
Code Issues 113 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

Pressing Enter in the Poll, Schedule or Report dialogs closes them and throws away what you typed (the header ✕ is the form's default submit button) #315

New Issue
Open
opened 2026-10-05 01:40:41 -04:00 by jared · 0 comments
jared commented 2026-10-05 01:40:41 -04:00
Owner
Copy Link
Copy Source

Several fork dialogs are <Box as="form" onSubmit=…> with the header close button inside the form. folds' IconButton renders a <button> with no type, so it is a submit button, and it comes first in the form. On implicit submission, pressing Enter in a text field "clicks" the form's first submit button. Here that's ✕, whose onClick closes the dialog.

Measured (Playwright):

Dialog Action Result
Create Poll (PollCreator.tsx) type "Where should we eat?" in the question, press Enter dialog closes, poll discarded, nothing sent
Schedule Message (ScheduleMessageModal.tsx) press Enter in the time field dialog closes, nothing scheduled
Report User (ReportUserModal.tsx) type a reason, press Enter dialog closes, no report request (clicking Report User works: POST /users/@aud_bob:localhost/report {"reason":"[Spam] …"} → 200)
Report Room (ReportRoomModal.tsx) same structure same code path, not run

The Report User controls in DOM order are BUTTON[type=submit] Close, BUTTON[type=button] Spam, INPUT reasonInput, BUTTON[type=submit] Report User.

Enter-to-submit is the natural move in a one-field dialog ("type reason ⏎"). Here it silently discards the input, and for polls it throws away a question and all its answers.

Fix: give every header/close IconButton inside a form type="button". Or move the header outside the <form> and use a form="…" attribute on the submit button. A lint rule would stop it coming back (e.g. react/button-has-type, or a small custom rule for IconButton inside as="form").

A static scan finds the same pattern in some upstream files: components/AccountDataEditor.tsx, features/common-settings/developer-tools/StateEventEditor.tsx, components/DeviceVerificationSetup.tsx, and a dialog in features/room/message/Message.tsx. I didn't exercise those; worth the same one-word fix (and an upstream PR).

Also verified in this pass: a private note on a user profile saves to io.lotus.user_notes and survives a reload.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

Several fork dialogs are `<Box as="form" onSubmit=…>` with the header close button **inside** the form. folds' `IconButton` renders a `<button>` with no `type`, so it is a **submit** button, and it comes first in the form. On implicit submission, pressing Enter in a text field "clicks" the form's first submit button. Here that's ✕, whose `onClick` closes the dialog. **Measured (Playwright):** | Dialog | Action | Result | |---|---|---| | **Create Poll** (`PollCreator.tsx`) | type "Where should we eat?" in the question, press Enter | dialog closes, **poll discarded**, nothing sent | | **Schedule Message** (`ScheduleMessageModal.tsx`) | press Enter in the time field | dialog closes, **nothing scheduled** | | **Report User** (`ReportUserModal.tsx`) | type a reason, press Enter | dialog closes, **no report request** (clicking **Report User** works: `POST /users/@aud_bob:localhost/report {"reason":"[Spam] …"}` → 200) | | **Report Room** (`ReportRoomModal.tsx`) | same structure | same code path, not run | The Report User controls in DOM order are `BUTTON[type=submit] Close`, `BUTTON[type=button] Spam`, `INPUT reasonInput`, `BUTTON[type=submit] Report User`. Enter-to-submit is the natural move in a one-field dialog ("type reason ⏎"). Here it silently discards the input, and for polls it throws away a question and all its answers. **Fix:** give every header/close `IconButton` inside a form `type="button"`. Or move the header outside the `<form>` and use a `form="…"` attribute on the submit button. A lint rule would stop it coming back (e.g. `react/button-has-type`, or a small custom rule for `IconButton` inside `as="form"`). A static scan finds the same pattern in some upstream files: `components/AccountDataEditor.tsx`, `features/common-settings/developer-tools/StateEventEditor.tsx`, `components/DeviceVerificationSetup.tsx`, and a dialog in `features/room/message/Message.tsx`. I didn't exercise those; worth the same one-word fix (and an upstream PR). Also verified in this pass: a private note on a user profile saves to `io.lotus.user_notes` and survives a reload. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: mediumarea: messaging labels 2026-10-05 01:40:41 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging bug priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#315