fix(settings): "ENTER for Newline" stays per device (#348) #356

Merged
jared merged 1 commits from fix/enter-newline-device-local into lotus 2026-10-12 16:07:34 -04:00
Owner

Fixes #348.

Settings sync mirrored enterForNewline to io.lotus.settings. Turning it on for a phone keyboard therefore switched the desktop to Ctrl+Enter-to-send, and the reverse. It's now in DEVICE_LOCAL_KEYS (test added).

Verified with one account on a phone profile and a desktop profile: toggling it on the phone leaves the desktop at Enter-to-send, and the setting no longer appears in the synced account data.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #348. Settings sync mirrored `enterForNewline` to `io.lotus.settings`. Turning it on for a phone keyboard therefore switched the desktop to Ctrl+Enter-to-send, and the reverse. It's now in `DEVICE_LOCAL_KEYS` (test added). **Verified** with one account on a phone profile and a desktop profile: toggling it on the phone leaves the desktop at Enter-to-send, and the setting no longer appears in the synced account data. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-12 15:28:56 -04:00
fix(settings): "ENTER for Newline" stays per device (#348)
CI / Build & Quality Checks (pull_request) Successful in 3m6s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 13s
CI / Playwright smoke (e2e) (pull_request) Successful in 14m37s
5130dfc9c8
Settings sync mirrored enterForNewline to io.lotus.settings, so turning it
on for a phone keyboard switched the desktop to Ctrl+Enter-to-send (and
vice versa). It is now in DEVICE_LOCAL_KEYS.

Verified with one account on a phone and a desktop profile: toggling it
on the phone leaves the desktop at Enter-to-send, and it is no longer in
the synced account data.

Fixes #348

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared merged commit 75089ecd3f into lotus 2026-10-12 16:07:34 -04:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#356