Merge pull request 'fix(settings): "ENTER for Newline" stays per device (#348)' (#356) from fix/enter-newline-device-local into lotus
CI / Build & Quality Checks (push) Canceled after 0s
CI / Trigger Desktop Build (push) Canceled after 0s
CI / Secret scan (gitleaks) (push) Canceled after 0s
CI / Docker image build & smoke test (push) Canceled after 0s
CI / Playwright smoke (e2e) (push) Canceled after 0s
CI / Build & Quality Checks (push) Canceled after 0s
CI / Trigger Desktop Build (push) Canceled after 0s
CI / Secret scan (gitleaks) (push) Canceled after 0s
CI / Docker image build & smoke test (push) Canceled after 0s
CI / Playwright smoke (e2e) (push) Canceled after 0s
This commit was merged in pull request #356.
This commit is contained in:
@@ -104,3 +104,9 @@ describe('buildSyncedContent', () => {
|
||||
assert.deepEqual(c.settings, pickSyncable(base));
|
||||
});
|
||||
});
|
||||
|
||||
describe('device-local keys', () => {
|
||||
it('keeps enterForNewline on each device (#348)', () => {
|
||||
assert.equal(DEVICE_LOCAL_KEYS.has('enterForNewline'), true);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -49,6 +49,9 @@ export const DEVICE_LOCAL_KEYS: ReadonlySet<keyof Settings> = new Set<keyof Sett
|
||||
'ringtoneVolume',
|
||||
'soundboardVolume',
|
||||
'cameraOnJoin',
|
||||
// [Gitea #348] Enter = new line suits a phone keyboard, Enter = send a desktop one;
|
||||
// syncing it switched the desktop to Ctrl+Enter when set on the phone.
|
||||
'enterForNewline',
|
||||
]);
|
||||
|
||||
/** The subset of `settings` that is synced (deep-copied so callers can't alias). */
|
||||
|
||||
Reference in New Issue
Block a user