fix(copy): soundboard wording, deafen hint, pin typo; keep Reddit context= (#279, #280) #435

2026-10-19T15:26:26-04:00

jared commented

2026-10-19 15:26:26 -04:00

Fixes #279 and #280.

#279, copy

Room Settings → Soundboard: the shared section said clips are "inherited by every room under this space" even for a plain room. The heading and text now follow room.isSpaceRoom(): "This room (shared) · shared with everyone in this room" vs "This space (shared) · … inherited by every room under this space".
Push to Deafen: the description reads "Press M during a call to mute your speakers." While rebinding it reads "Press a key to bind it, or Escape to cancel." Escape is only mentioned when it applies.
Pinned messages: "can pin a messages" → "can pin a message".

#280, Reddit context=: the tracking stripper removed context. On a comment permalink, ?context=N shows the N parent comments, i.e. the conversation the sender meant to share. Only share_id and rdt are stripped now. New test: …/xyz/?context=3&share_id=1 → …/xyz/?context=3 (14/14 in the file).

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #279 and #280. **#279, copy** - **Room Settings → Soundboard:** the shared section said clips are "inherited by every room under this space" even for a plain room. The heading and text now follow `room.isSpaceRoom()`: "This room (shared) · shared with everyone in this room" vs "This space (shared) · … inherited by every room under this space". - **Push to Deafen:** the description reads "Press M during a call to mute your speakers." While rebinding it reads "Press a key to bind it, or Escape to cancel." Escape is only mentioned when it applies. - **Pinned messages:** "can pin a messages" → "can pin a message". **#280, Reddit `context=`:** the tracking stripper removed `context`. On a comment permalink, `?context=N` shows the N parent comments, i.e. the conversation the sender meant to share. Only `share_id` and `rdt` are stripped now. New test: `…/xyz/?context=3&share_id=1` → `…/xyz/?context=3` (14/14 in the file). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

jared added 1 commit 2026-10-19 15:26:27 -04:00

fix(copy): soundboard room/space wording, deafen Escape hint, pin typo; keep Reddit context= (#279 , #280 )

CI / Build & Quality Checks (pull_request) Successful in 1m50s

Details

CI / Trigger Desktop Build (pull_request) Skipped

Details

CI / Docker image build & smoke test (pull_request) Skipped

Details

CI / Secret scan (gitleaks) (pull_request) Successful in 13s

Details

CI / Playwright smoke (e2e) (pull_request) Successful in 12m29s

Details

8bfb8737d6

#279: Room Settings → Soundboard said clips are "inherited by every room
under this space" for plain rooms too; the wording now follows
room.isSpaceRoom(). The Push to Deafen description only mentions Escape
while rebinding. "can pin a messages" → "can pin a message".

#280: the tracking stripper removed Reddit's context=, which is what
makes a comment permalink show its parent comments. Only share_id and
rdt are stripped now.

Fixes #279
Fixes #280

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

jared referenced this pull request

2026-10-19 15:36:39 -04:00

Client audit 2026-10: tracking index #281

jared merged commit 1a0e581f21 into lotus

2026-10-19 16:54:31 -04:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/cinny#435