LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Copy nits: room soundboard text talks about a 'space', Push to Deafen help, a pinned-messages typo #279

New Issue
Closed
opened 2026-10-04 17:41:33 -04:00 by jared · 1 comment
jared commented 2026-10-04 17:41:33 -04:00
Owner
Copy Link
Copy Source

Small text fixes found while sweeping every screen:

  • Room Settings → Soundboard (src/app/features/common-settings/soundboard/Soundboard.tsx:43). The text says "Clips here are shared with everyone, and inherited by every room under this space", even when the settings are for a plain room (not a space).
    • Fix: pick the wording based on room.isSpaceRoom().
  • Settings → Calls → Push to Deafen (General.tsx:2095). The text says "Press M during a call to mute your speakers. Press Escape to cancel rebind." The Escape hint only makes sense while rebinding.
    • Fix: show it only in rebinding mode.
  • Pinned messages empty state (src/app/features/room/room-pin-menu/RoomPinMenu.tsx:534). The text says "Users with sufficient power level can pin a messages from its context menu." The typo comes from upstream.
    • Fix: "can pin a message from its context menu".

More context

No code risk; all are string changes. Bundle them with the next Settings PR.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

Small text fixes found while sweeping every screen: - **Room Settings → Soundboard** (src/app/features/common-settings/soundboard/Soundboard.tsx:43). The text says "Clips here are shared with everyone, and inherited by every room under this space", even when the settings are for a plain room (not a space). - Fix: pick the wording based on `room.isSpaceRoom()`. - **Settings → Calls → Push to Deafen** (General.tsx:2095). The text says "Press M during a call to mute your speakers. Press Escape to cancel rebind." The Escape hint only makes sense while rebinding. - Fix: show it only in rebinding mode. - **Pinned messages empty state** (src/app/features/room/room-pin-menu/RoomPinMenu.tsx:534). The text says "Users with sufficient power level can pin **a messages** from its context menu." The typo comes from upstream. - Fix: "can pin a message from its context menu". ### More context No code risk; all are string changes. Bundle them with the next Settings PR. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the priority: lowuxarea: settings labels 2026-10-04 17:41:33 -04:00
jared commented 2026-10-04 21:19:33 -04:00
Author
Owner
Copy Link
Copy Source

Round 4 addition: Settings → General → Seasonal Theme labels Autumn as "Sep 21 – Oct 14", but SEASON_SCHEDULE gives Deep Space (Oct 4 – 10) priority, so on "Auto" Autumn is actually off for a week in the middle of its stated range. Either show it as "Sep 21 – Oct 3, Oct 11 – 14" or note "(except Deep Space week)".

**Round 4 addition:** Settings → General → Seasonal Theme labels **Autumn** as "Sep 21 – Oct 14", but `SEASON_SCHEDULE` gives **Deep Space** (Oct 4 – 10) priority, so on "Auto" Autumn is actually off for a week in the middle of its stated range. Either show it as "Sep 21 – Oct 3, Oct 11 – 14" or note "(except Deep Space week)".
jared closed this issue 2026-10-19 16:54:31 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: settings priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#279