LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Tracking stripper removes Reddit context=, which changes what a comment permalink shows #280

New Issue
Closed
opened 2026-10-04 17:41:33 -04:00 by jared · 1 comment
jared commented 2026-10-04 17:41:33 -04:00
Owner
Copy Link
Copy Source

stripTrackingParams removes context on reddit.com (src/app/utils/urlTracking.ts:105-107). On Reddit, ?context=N is functional, not tracking: a comment permalink with context=3 shows the three parent comments above it. After stripping, recipients see the comment alone, without the conversation the sender meant to share.

Fix: keep context. Only share_id and rdt are tracking.

More context

Introduced by 5b0d3554 (2026-09-17, #103).

Acceptance criteria: stripTrackingParams('https://www.reddit.com/r/x/comments/abc/def/xyz/?context=3&share_id=1') returns …?context=3; unit test added.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

`stripTrackingParams` removes `context` on `reddit.com` (src/app/utils/urlTracking.ts:105-107). On Reddit, `?context=N` is functional, not tracking: a comment permalink with `context=3` shows the three parent comments above it. After stripping, recipients see the comment alone, without the conversation the sender meant to share. **Fix:** keep `context`. Only `share_id` and `rdt` are tracking. ### More context **Introduced by** 5b0d3554 (2026-09-17, #103). **Acceptance criteria:** `stripTrackingParams('https://www.reddit.com/r/x/comments/abc/def/xyz/?context=3&share_id=1')` returns `…?context=3`; unit test added. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: lowarea: messaging labels 2026-10-04 17:41:33 -04:00
jared commented 2026-10-05 23:38:29 -04:00
Author
Owner
Copy Link
Copy Source

Same class: the Instagram entry (utils/urlTracking.ts, hosts: ['instagram.com'], params: ['igsh', 'img_index']) strips img_index, which isn't tracking. It selects which image of a carousel post opens (…/p/<id>/?img_index=3 shows the third photo), so the shared link opens on image 1. The rest of the list looks safe: no t/ref/list/index on YouTube, and X's s/t really are share-tracking there.

Same class: the Instagram entry (`utils/urlTracking.ts`, `hosts: ['instagram.com'], params: ['igsh', 'img_index']`) strips **`img_index`**, which isn't tracking. It selects which image of a carousel post opens (`…/p/<id>/?img_index=3` shows the third photo), so the shared link opens on image 1. The rest of the list looks safe: no `t`/`ref`/`list`/`index` on YouTube, and X's `s`/`t` really are share-tracking there.
jared closed this issue 2026-10-19 16:54:32 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging bug priority: low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#280