fix(calls): no "the shared window was closed" toast when an admin turns sharing off (#297)

When a room admin turned off Allow Screen Sharing, the sharer got two
toasts: the correct "turned off by a room admin" and the fork's
"ended" notice, "the shared window was closed", which was wrong. Skip
the ended notice while the room policy forbids sharing.

Fixes #297

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

src/app/hooks/useMessageTranslation.ts

@@ -12,8 +12,7 @@ import {
   markAutoTranslateTried,
 } from '../state/translation';
 import { chromeTranslationEngine as engine } from '../utils/translation/chromeEngine';
-import { sameLanguage, translateSkipMessage } from '../utils/translation/langUtils';
-import { toastQueueAtom } from '../state/toast';
+import { sameLanguage } from '../utils/translation/langUtils';
 
 export type MsgTranslationStatus =
   | 'idle' // not translating (original shown)
@@ -53,7 +52,6 @@ export const useMessageTranslation = (eventId: string, text: string): MsgTransla
   // Write-only: reading the whole cache array here (via useAtom) would
   // resubscribe this message to every other message's writes. [Gitea #39]
   const setCache = useSetAtom(translationCacheAtom);
-  const setToast = useSetAtom(toastQueueAtom);
 
   // The key includes a fingerprint of `text`, so an edit (same event id, new
   // body) misses the old entry and re-translates instead of showing stale
@@ -126,16 +124,6 @@ export const useMessageTranslation = (eventId: string, text: string): MsgTransla
         if (!from || sameLanguage(from, targetLang)) {
           setStatus('skipped');
           setActive(false);
-          // [Gitea #287] Say why nothing happened instead of silently undoing
-          // the click (no chip shows once translation is switched back off).
-          setToast({
-            id: `translate-skipped-${eventId}-${Date.now()}`,
-            displayName: 'Translate',
-            body: translateSkipMessage(from, targetLang),
-            roomName: '',
-            roomId: '',
-            onClick: () => undefined,
-          });
           return;
         }
         setFromLang(from);
@@ -166,7 +154,7 @@ export const useMessageTranslation = (eventId: string, text: string): MsgTransla
       // Invalidate this run's writes if inputs change / unmount.
       runIdRef.current += 1;
     };
-  }, [active, cached, supported, text, targetLang, key, setActive, setCache, setToast, eventId]);
+  }, [active, cached, supported, text, targetLang, key, setActive, setCache]);
 
   // When switched off, drop back to idle (keep the cached translation around so
   // toggling back on is instant).

src/app/hooks/useScreenshareNotices.test.ts

@@ -0,0 +1,10 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { shouldShowScreenshareNotice } from './useScreenshareNotices';
+
+test('shouldShowScreenshareNotice: no "window was closed" when an admin turned sharing off (#297)', () => {
+  assert.equal(shouldShowScreenshareNotice('ended', false), false);
+  assert.equal(shouldShowScreenshareNotice('ended', true), true);
+  assert.equal(shouldShowScreenshareNotice('no-frames', false), true);
+  assert.equal(shouldShowScreenshareNotice('alone', true), true);
+});

src/app/hooks/useScreenshareNotices.ts

@@ -1,8 +1,9 @@
-import { useEffect } from 'react';
+import { useEffect, useRef } from 'react';
 import { useSetAtom } from 'jotai';
 import { Icons } from 'folds';
 import { CallEmbed } from '../plugins/call';
 import { toastQueueAtom } from '../state/toast';
+import { useRoomCallPolicy } from './useRoomCallPolicy';
 
 export type ScreenshareNoticeKind = 'ended' | 'no-frames' | 'alone';
 
@@ -19,18 +20,32 @@ export const describeScreenshareNotice = (kind: ScreenshareNoticeKind): string |
   }
 };
 
+/** Pure: a policy-forced stop is explained by its own toast (#297). */
+export const shouldShowScreenshareNotice = (
+  kind: ScreenshareNoticeKind,
+  allowScreenshare: boolean,
+): boolean => !(kind === 'ended' && !allowScreenshare);
+
 /**
  * [Gitea EC#39] Toast the fork's io.lotus.screenshare_notice: shared window
  * closed, no frames for a while, or a long share with nobody watching.
  */
 export function useScreenshareNotices(embed: CallEmbed): void {
   const setToast = useSetAtom(toastQueueAtom);
+  // [Gitea #297] When a room admin turns screen sharing off, the share ends
+  // and the fork reports `ended` ("the shared window was closed"), which is
+  // wrong; useCallPolicyRevokedToast already says what happened.
+  const { allowScreenshare } = useRoomCallPolicy(embed.room);
+  const allowRef = useRef(allowScreenshare);
+  allowRef.current = allowScreenshare;
   useEffect(
     () =>
       embed.listenAction<{ data?: { kind?: ScreenshareNoticeKind } }>(
         'io.lotus.screenshare_notice',
         (evt) => {
-          const body = describeScreenshareNotice(evt.detail?.data?.kind as ScreenshareNoticeKind);
+          const kind = evt.detail?.data?.kind as ScreenshareNoticeKind;
+          if (!shouldShowScreenshareNotice(kind, allowRef.current)) return;
+          const body = describeScreenshareNotice(kind);
           if (!body) return;
           setToast({
             id: `screenshare-${evt.detail?.data?.kind}-${Date.now()}`,

src/app/utils/translation/langUtils.ts

@@ -85,9 +85,3 @@ export function languageName(code: string, uiLocale = 'en'): string {
 export function isSupportedTargetLang(code: string): boolean {
   return CURATED_NAME.has(normalizeLang(code));
 }
-
-/** Pure: why a manual Translate did nothing (#287). */
-export const translateSkipMessage = (from: string | undefined, targetLang: string): string =>
-  from
-    ? `This message is already in ${languageName(targetLang) || targetLang}.`
-    : "Couldn't tell what language this message is in, so it wasn't translated.";

src/app/utils/translation/translateSkip.test.ts

@@ -1,8 +0,0 @@
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-import { translateSkipMessage } from './langUtils';
-
-test('translateSkipMessage explains a Translate that did nothing (#287)', () => {
-  assert.equal(translateSkipMessage('en', 'en'), 'This message is already in English.');
-  assert.match(translateSkipMessage(undefined, 'en'), /^Couldn't tell what language/);
-});