fix(settings): desktop-only settings get their own Desktop section (#290)

Custom Window Chrome, Launch on login / When I close the window and the
keychain status sat inside Appearance, between Monochrome Mode and
Twitter Emoji. Move them to a Desktop section (above App Updates),
rendered only in the desktop app.

Fixes #290

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

src/app/features/settings/general/General.tsx

@@ -596,10 +596,6 @@ function Appearance() {
         />
       </SequenceCard>
 
-      <DesktopChromeSetting />
-      <AutostartSetting />
-      <KeychainMirrorSetting />
-
       <SequenceCard className={SequenceCardStyle} variant="SurfaceVariant" direction="Column">
         <SettingTile
           title="Twitter Emoji"
@@ -2856,6 +2852,23 @@ function PackageUpdate({ help }: { help: NonNullable<ReturnType<typeof packageUp
   );
 }
 
+/**
+ * [Gitea #290] Desktop-only settings in their own section (they used to sit
+ * inside Appearance, between Monochrome Mode and Twitter Emoji). Renders
+ * nothing outside the desktop app.
+ */
+function DesktopSettings() {
+  if (!isTauriEnv()) return null;
+  return (
+    <Box direction="Column" gap="100">
+      <Text size="L400">Desktop</Text>
+      <AutostartSetting />
+      <KeychainMirrorSetting />
+      <DesktopChromeSetting />
+    </Box>
+  );
+}
+
 function AppUpdates() {
   const { isTauri, status, check, install, installKind } = useTauriUpdater();
   if (!isTauri) return null;
@@ -2964,6 +2977,7 @@ export function General({ requestClose }: GeneralProps) {
               <StorageUsage />
               <SettingsSyncSection />
               <Calls />
+              <DesktopSettings />
               <AppUpdates />
             </Box>
           </PageContent>

src/app/hooks/useScreenshareNotices.test.ts

@@ -1,10 +0,0 @@
-import { test } from 'node:test';
-import assert from 'node:assert/strict';
-import { shouldShowScreenshareNotice } from './useScreenshareNotices';
-
-test('shouldShowScreenshareNotice: no "window was closed" when an admin turned sharing off (#297)', () => {
-  assert.equal(shouldShowScreenshareNotice('ended', false), false);
-  assert.equal(shouldShowScreenshareNotice('ended', true), true);
-  assert.equal(shouldShowScreenshareNotice('no-frames', false), true);
-  assert.equal(shouldShowScreenshareNotice('alone', true), true);
-});

src/app/hooks/useScreenshareNotices.ts

@@ -1,9 +1,8 @@
-import { useEffect, useRef } from 'react';
+import { useEffect } from 'react';
 import { useSetAtom } from 'jotai';
 import { Icons } from 'folds';
 import { CallEmbed } from '../plugins/call';
 import { toastQueueAtom } from '../state/toast';
-import { useRoomCallPolicy } from './useRoomCallPolicy';
 
 export type ScreenshareNoticeKind = 'ended' | 'no-frames' | 'alone';
 
@@ -20,32 +19,18 @@ export const describeScreenshareNotice = (kind: ScreenshareNoticeKind): string |
   }
 };
 
-/** Pure: a policy-forced stop is explained by its own toast (#297). */
-export const shouldShowScreenshareNotice = (
-  kind: ScreenshareNoticeKind,
-  allowScreenshare: boolean,
-): boolean => !(kind === 'ended' && !allowScreenshare);
-
 /**
  * [Gitea EC#39] Toast the fork's io.lotus.screenshare_notice: shared window
  * closed, no frames for a while, or a long share with nobody watching.
  */
 export function useScreenshareNotices(embed: CallEmbed): void {
   const setToast = useSetAtom(toastQueueAtom);
-  // [Gitea #297] When a room admin turns screen sharing off, the share ends
-  // and the fork reports `ended` ("the shared window was closed"), which is
-  // wrong; useCallPolicyRevokedToast already says what happened.
-  const { allowScreenshare } = useRoomCallPolicy(embed.room);
-  const allowRef = useRef(allowScreenshare);
-  allowRef.current = allowScreenshare;
   useEffect(
     () =>
       embed.listenAction<{ data?: { kind?: ScreenshareNoticeKind } }>(
         'io.lotus.screenshare_notice',
         (evt) => {
-          const kind = evt.detail?.data?.kind as ScreenshareNoticeKind;
-          if (!shouldShowScreenshareNotice(kind, allowRef.current)) return;
-          const body = describeScreenshareNotice(kind);
+          const body = describeScreenshareNotice(evt.detail?.data?.kind as ScreenshareNoticeKind);
           if (!body) return;
           setToast({
             id: `screenshare-${evt.detail?.data?.kind}-${Date.now()}`,