Avatar-decoration slug from a remote profile is interpolated into a URL unvalidated #64
Closed
opened 2026-09-12 01:51:22 -04:00 by jared
·
0 comments
No Branch/Tag Specified
lotus
update-packages
sw-fix
read-me-update
image-path-changes
dm-calls
fix-2469
renovate/element-hq-element-call-embedded-0.x
renovate/npm-i18next-http-backend-vulnerability
renovate/npm-vite-vulnerability
dev
docs-update
more-theme
fix-257
imporve-thread-reply
revert-2402-improve-menu-congestion
mxidColor-toggle
update-sw-main-msg
v4.11.1
v4.10.5
v4.10.4
v4.10.3
v4.10.2
v4.10.1
v4.10.0
v4.9.1
v4.9.0
v4.8.1
v4.8.0
v4.7.1
v4.7.0
v4.6.0
v4.5.1
v4.5.0
v4.4.0
v4.3.2
v4.3.0
v4.2.3
v4.2.2
v4.2.1
v4.2.0
v4.1.0
v4.0.3
v4.0.0
v3.2.0
v3.1.0
v3.0.0
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.8.2
v1.8.1
v1.8.0
v1.7.0
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.0
v1.3.2
v1.3.1
v1.3.0
v1.2.1
v1.2.0
v1.1.0
v1.0.0
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
Milestone
No items
No Milestone
Audit 2026-09 · Medium & Low
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#64
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: low · Type: security · Confidence: high
Location:
src/app/hooks/useAvatarDecoration.ts:52-56,src/app/features/lotus/avatarDecorations.ts:191-193,src/app/components/avatar-decoration/AvatarDecoration.tsx:45,src/app/features/lotus/LotusDecorationPusher.tsx:25Problem
io.lotus.avatar_decorationis a free-form MSC4133 profile field controlled by the remoteuser (and their homeserver). Its value is passed straight to
decorationUrl(slug)→${CDN}/${slug}.pngwith no length limit, character filter, or membership check againstALL_DECORATIONS. Because the CDN base is absolute the attacker cannot change the host, but they canchoose an arbitrary path, add a query string (
slug = "x?u=<victim-marker>"), or supply a multi-kBstring that lands in the DOM as an
<img src>for every avatar of that user — and the sameunvalidated URL is forwarded into the Element Call iframe via
io.lotus.decorations.How to trigger
set your own
io.lotus.avatar_decorationprofile field (viaPUT /_matrix/client/v3/profile/{userId}/io.lotus.avatar_decoration) to../../anything?probe=1; every client that renders your avatar issues that request to the decorations CDN.Suggested fix
accept the value only when it matches a slug in
ALL_DECORATIONS(or at minimum/^[a-z0-9_]{1,32}$/), and drop it otherwise.Filed from the September 2026 client audit (branch
lotus@4bea4895).