Decoration URLs derive from an unvalidated arbitrary profile field #28
Closed
opened 2026-09-12 02:13:12 -04:00 by jared
·
0 comments
No Branch/Tag Specified
lotus
chore/dev-tool-security
feat/expected-devices
lotus-upstream-v0.28.0
feat/call-summary-details
feat/soundboard-mic-mix
feat/mobile-self-tile
feat/screenshare-audio-state
feat/decorations-origin
docs/lotus-call-error
lotus-stall-retry
docs/lotus-protocol
lotus-soundboard-not-permitted
lotus-mic-sampler-churn
lotus-call-error
fix/audio-output-list
lotus-notify-none
lotus-screenshare-prompt
lotus-call-origin
v0.28.0-lotus.4
v0.28.0-lotus.3
v0.28.0-lotus.2
v0.28.0-lotus.1
v0.25.0-lotus.29
v0.25.0-lotus.28
v0.25.0-lotus.27
v0.25.0-lotus.26
v0.25.0-lotus.25
v0.25.0-lotus.24
v0.25.0-lotus.23
v0.25.0-lotus.22
v0.25.0-lotus.21
v0.25.0-lotus.20
v0.25.0-lotus.19
v0.25.0-lotus.18
v0.25.0-lotus.17
v0.25.0-lotus.16
v0.25.0-lotus.15
v0.25.0-lotus.14
v0.25.0-lotus.13
v0.25.0-lotus.12
v0.25.0-lotus.11
v0.25.0-lotus.10
v0.25.0-lotus.9
v0.25.0-lotus.8
v0.25.0-lotus.7
v0.25.0-lotus.6
v0.25.0-lotus.5
v0.25.0-lotus.4
v0.25.0-lotus.3
v0.25.0-lotus.2
v0.25.0-lotus.1
v0.20.1
Labels
Clear labels
a11y
area: audio-pipeline
area: build-publish
area: deafen
area: decorations
area: denoise
area: livekit
area: mobile-ui
area: soundboard-inject
area: upstream-sync
area: widget-actions
bug
dependencies
docs
enhancement
performance
priority: critical
priority: high
priority: low
priority: medium
research
security
tech-debt
ux
Accessibility
Fork area: audio-pipeline
Fork area: build-publish
Fork area: deafen
Fork area: decorations
Fork area: denoise
Fork area: livekit
Fork area: mobile-ui
Fork area: soundboard-inject
Fork area: upstream-sync
Fork area: widget-actions
Something is not working
Package versions and advisories
Docs wrong or missing
New feature
Audio pipeline cost, re-render storms, leaks
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Origin checks, capability leaks, media/key handling
Code health, fragile patterns
Usability or visual inconsistency
Milestone
No items
No Milestone
EC fork audit 2026-09 · Medium & Low
Projects
Clear projects
No projects
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/element-call#28
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: low · Type: security · Confidence: high
Location:
src/lotus/lotusDecorations.ts:44-52,/root/code/cinny/src/app/hooks/useAvatarDecoration.ts:52-56,/root/code/cinny/src/app/features/lotus/avatarDecorations.ts:191-193Problem
the chain is: any room member (including federated) sets the MSC4133 profile field
io.lotus.avatar_decorationto an arbitrary string →useAvatarDecorationreturns it verbatim with no check againstDECORATION_CATEGORIES→decorationUrl(slug)interpolates it into`${CDN}/${slug}.png`with noencodeURIComponent→ pushed overio.lotus.decorations→ EC'ssafeImageUrlaccepts it because it only checksprotocol === "https:" || "blob:", with no host allowlist →<img src>on every participant's tile. The origin cannot be changed (the CDN prefix is absolute), but../../..segments traverse to an arbitrary path ondrive.lotusguild.org, and?/#in the slug let a hostile member control the query string of a request every other caller's browser makes. NotesafeImageUrlwould also happily render any https origin, so the only thing preventing a third-party image beacon on every tile is that the host happens to build the URL itself.Cross-reference: the host-side slug validation is LotusGuild/cinny#64. This issue is the EC side:
safeImageUrlshould pin to the expected decoration origin(s), not any https host.How to trigger
set your own
io.lotus.avatar_decorationprofile field to../../../../whatever?x=1, join a call with other Lotus users.Suggested fix
validate the slug against the known catalog (or
/^[a-z0-9_]+$/) in cinny before building the URL, and pinsafeImageUrlto the expected decoration origin(s) in EC rather than accepting any https host.Filed from the September 2026 audit (branch
lotus).