CSS fixes: - Fix [ ] brackets appearing below button text by replacing display:inline-flex with display:inline-block + white-space:nowrap on .btn — removes cross-browser flex pseudo-element inconsistency as root cause - Remove conflicting .btn::before ripple block (position:absolute was overriding bracket content positioning) - Remove overflow:hidden from .btn which was clipping bracket content - Fix body::after duplicate rule causing GPU layer blink (second position:fixed rule re-created compositor layer, overriding display:none suppression) - Replace all transition:all with scoped property transitions in dashboard.css, ticket.css, base.css (prevents full CSS property evaluation on every hover) - Convert pulse-warning/pulse-critical keyframes from box-shadow to opacity animation (GPU-composited, eliminates CPU repaints at 60fps) - Fix mobile *::before/*::after blanket content:none rule — now targets only decorative frame glyphs, preserving button brackets and status indicators - Remove --terminal-green-dim override that broke .lt-btn hover backgrounds JS fixes: - Fix all lt.lt.toast.* double-prefix instances in dashboard.js - Add null guard before .appendChild() on bulkAssignUser select - Replace all remaining emoji with terminal bracket notation (dashboard.js, ticket.js, markdown.js) - Migrate all toast.*() shim calls to lt.toast.* across all JS files View fixes: - Remove hardcoded [ ] brackets from .btn buttons (CSS now adds them) - Replace all emoji with terminal bracket notation in all views and admin views - Add missing CSP nonces to AuditLogView.php and UserActivityView.php script tags - Bump CSS version strings to ?v=20260319b for cache busting Security fixes: - update_ticket.php: add authorization check (non-admins can only edit their own or assigned tickets) - add_comment.php: validate and cast ticket_id to integer with 400 response - clone_ticket.php: fix unconditional session_start(), add ticket ID validation, add internal ticket access check - bulk_operation.php: add HTTP 401/403 status codes on auth failures - upload_attachment.php: fix missing $conn arg in AttachmentModel constructor - assign_ticket.php: add ticket existence check and permission verification Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
138 lines
4.3 KiB
PHP
138 lines
4.3 KiB
PHP
<?php
|
|
// Disable error display in the output
|
|
ini_set('display_errors', 0);
|
|
error_reporting(E_ALL);
|
|
|
|
// Apply rate limiting
|
|
require_once dirname(__DIR__) . '/middleware/RateLimitMiddleware.php';
|
|
RateLimitMiddleware::apply('api');
|
|
|
|
// Start output buffering to capture any errors
|
|
ob_start();
|
|
|
|
try {
|
|
// Include required files with proper error handling
|
|
$configPath = dirname(__DIR__) . '/config/config.php';
|
|
$commentModelPath = dirname(__DIR__) . '/models/CommentModel.php';
|
|
$auditLogModelPath = dirname(__DIR__) . '/models/AuditLogModel.php';
|
|
|
|
if (!file_exists($configPath)) {
|
|
throw new Exception("Config file not found: $configPath");
|
|
}
|
|
|
|
if (!file_exists($commentModelPath)) {
|
|
throw new Exception("CommentModel file not found: $commentModelPath");
|
|
}
|
|
|
|
require_once $configPath;
|
|
require_once $commentModelPath;
|
|
require_once $auditLogModelPath;
|
|
require_once dirname(__DIR__) . '/helpers/Database.php';
|
|
|
|
// Check authentication via session
|
|
if (session_status() === PHP_SESSION_NONE) {
|
|
session_start();
|
|
}
|
|
if (!isset($_SESSION['user']) || !isset($_SESSION['user']['user_id'])) {
|
|
throw new Exception("Authentication required");
|
|
}
|
|
|
|
// CSRF Protection
|
|
require_once dirname(__DIR__) . '/middleware/CsrfMiddleware.php';
|
|
if ($_SERVER['REQUEST_METHOD'] === 'POST') {
|
|
$csrfToken = $_SERVER['HTTP_X_CSRF_TOKEN'] ?? '';
|
|
if (!CsrfMiddleware::validateToken($csrfToken)) {
|
|
http_response_code(403);
|
|
header('Content-Type: application/json');
|
|
echo json_encode(['success' => false, 'error' => 'Invalid CSRF token']);
|
|
exit;
|
|
}
|
|
}
|
|
|
|
$currentUser = $_SESSION['user'];
|
|
$userId = $currentUser['user_id'];
|
|
|
|
// Use centralized database connection
|
|
$conn = Database::getConnection();
|
|
|
|
// Get POST data
|
|
$data = json_decode(file_get_contents('php://input'), true);
|
|
|
|
if (!$data) {
|
|
throw new Exception("Invalid JSON data received");
|
|
}
|
|
|
|
$ticketId = isset($data['ticket_id']) ? (int)$data['ticket_id'] : 0;
|
|
if ($ticketId <= 0) {
|
|
http_response_code(400);
|
|
ob_end_clean();
|
|
header('Content-Type: application/json');
|
|
echo json_encode(['success' => false, 'error' => 'Invalid ticket ID']);
|
|
exit;
|
|
}
|
|
|
|
// Initialize models
|
|
$commentModel = new CommentModel($conn);
|
|
$auditLog = new AuditLogModel($conn);
|
|
|
|
// Extract @mentions from comment text
|
|
$mentions = $commentModel->extractMentions($data['comment_text'] ?? '');
|
|
$mentionedUsers = [];
|
|
if (!empty($mentions)) {
|
|
$mentionedUsers = $commentModel->getMentionedUsers($mentions);
|
|
}
|
|
|
|
// Add comment with user tracking
|
|
$result = $commentModel->addComment($ticketId, $data, $userId);
|
|
|
|
// Log comment creation to audit log
|
|
if ($result['success'] && isset($result['comment_id'])) {
|
|
$auditLog->logCommentCreate($userId, $result['comment_id'], $ticketId);
|
|
|
|
// Log mentions to audit log
|
|
foreach ($mentionedUsers as $mentionedUser) {
|
|
$auditLog->log(
|
|
$userId,
|
|
'mention',
|
|
'user',
|
|
(string)$mentionedUser['user_id'],
|
|
[
|
|
'ticket_id' => $ticketId,
|
|
'comment_id' => $result['comment_id'],
|
|
'mentioned_username' => $mentionedUser['username']
|
|
]
|
|
);
|
|
}
|
|
|
|
// Add mentioned users to result for frontend
|
|
$result['mentions'] = array_map(function($u) {
|
|
return $u['username'];
|
|
}, $mentionedUsers);
|
|
}
|
|
|
|
// Add user display name to result for frontend
|
|
if ($result['success']) {
|
|
$result['user_name'] = $currentUser['display_name'] ?? $currentUser['username'];
|
|
}
|
|
|
|
// Discard any unexpected output
|
|
ob_end_clean();
|
|
|
|
// Return JSON response
|
|
header('Content-Type: application/json');
|
|
echo json_encode($result);
|
|
|
|
} catch (Exception $e) {
|
|
// Discard any unexpected output
|
|
ob_end_clean();
|
|
|
|
// Log error details but don't expose to client
|
|
error_log("Add comment API error: " . $e->getMessage());
|
|
|
|
// Return error response
|
|
header('Content-Type: application/json');
|
|
echo json_encode([
|
|
'success' => false,
|
|
'error' => 'An internal error occurred'
|
|
]);
|
|
} |