Delete dead RecurringTicketModel::updateAfterRun() (#90)
Zero callers anywhere in the codebase — superseded by claimForRun(), which the cron script actually uses and which additionally guards against the double-fire race between concurrent cron invocations that this method lacked. Removing it so a future reuse doesn't silently reintroduce that race. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGDKHiU5RJdo3dqQUDow3X
This commit is contained in:
@@ -189,30 +189,6 @@ class RecurringTicketModel
|
|||||||
return $claimed;
|
return $claimed;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Update last run and calculate next run time
|
|
||||||
*/
|
|
||||||
public function updateAfterRun($recurringId)
|
|
||||||
{
|
|
||||||
$recurring = $this->getById($recurringId);
|
|
||||||
if (!$recurring) {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
$nextRun = $this->calculateNextRunTime(
|
|
||||||
$recurring['schedule_type'],
|
|
||||||
$recurring['schedule_day'],
|
|
||||||
$recurring['schedule_time']
|
|
||||||
);
|
|
||||||
|
|
||||||
$sql = "UPDATE recurring_tickets SET last_run_at = NOW(), next_run_at = ? WHERE recurring_id = ?";
|
|
||||||
$stmt = $this->conn->prepare($sql);
|
|
||||||
$stmt->bind_param('si', $nextRun, $recurringId);
|
|
||||||
$success = $stmt->execute();
|
|
||||||
$stmt->close();
|
|
||||||
return $success;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Calculate the next run time based on schedule
|
* Calculate the next run time based on schedule
|
||||||
*/
|
*/
|
||||||
|
|||||||
Reference in New Issue
Block a user