RecurringTicketModel::updateAfterRun() is dead code lacking the double-fire race guard of the method that replaced it #90

New Issue

2026-09-01T00:08:19-04:00

jared commented

2026-09-01 00:08:19 -04:00

Severity: Low

models/RecurringTicketModel.php::updateAfterRun() has zero callers anywhere in the codebase — superseded by the atomic claimForRun(), which the cron script actually uses. Harmless as dead code, but it lacks claimForRun's WHERE ... AND next_run_at <= NOW() conditional-claim guard that prevents the double-fire race between concurrent cron invocations. If anyone reuses updateAfterRun() later assuming it's equivalent/interchangeable with claimForRun(), they'd silently reintroduce that race.

Fix: Delete updateAfterRun() to remove the trap for future maintainers.

**Severity:** Low `models/RecurringTicketModel.php::updateAfterRun()` has zero callers anywhere in the codebase — superseded by the atomic `claimForRun()`, which the cron script actually uses. Harmless as dead code, but it lacks `claimForRun`'s `WHERE ... AND next_run_at <= NOW()` conditional-claim guard that prevents the double-fire race between concurrent cron invocations. If anyone reuses `updateAfterRun()` later assuming it's equivalent/interchangeable with `claimForRun()`, they'd silently reintroduce that race. **Fix:** Delete `updateAfterRun()` to remove the trap for future maintainers.

jared added the dead-code priority/low labels 2026-09-08 10:15:49 -04:00

jared referenced this issue from a commit

2026-09-08 11:59:38 -04:00

Delete dead RecurringTicketModel::updateAfterRun() (#90)

jared referenced this issue from a commit

2026-09-08 15:39:42 -04:00

Merge development into main: 15-issue triage + fix batch

Sign in to join this conversation.