LotusGuild/hwmonDaemon
2
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Cache drive details to eliminate redundant smartctl calls

Browse Source 
Add per-run cache for _get_drive_details() results. Each drive is
queried once via smartctl -i and the result is reused across SMART
health checks and ticket creation.

Resolves #15

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jared Vititoe
2026-02-10 13:00:25 -05:00
parent 9f9cc1b763
commit 308a8d5c5c
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
hwmonDaemon.py
View File

@@ -665,6 +665,9 @@ class SystemHealthMonitor:
# Ensure history directory exists # Ensure history directory exists
os.makedirs(self.CONFIG['HISTORY_DIR'], exist_ok=True) os.makedirs(self.CONFIG['HISTORY_DIR'], exist_ok=True)
# Drive details cache (per-run, cleared on next execution)
self._drive_details_cache = {}
def _enforce_storage_limit(self, history_dir: str, max_bytes: int = None): def _enforce_storage_limit(self, history_dir: str, max_bytes: int = None):
""" """
Delete oldest history files if directory exceeds size limit. Delete oldest history files if directory exceeds size limit.
@@ -1072,7 +1075,10 @@ class SystemHealthMonitor:
# DRIVE HEALTH CHECKING METHODS # DRIVE HEALTH CHECKING METHODS
# ============================================================================= # =============================================================================
def _get_drive_details(self, device: str) -> Dict[str, str]: def _get_drive_details(self, device: str) -> Dict[str, str]:
"""Get detailed drive information using smartctl.""" """Get detailed drive information using smartctl (cached per run)."""
if device in self._drive_details_cache:
return self._drive_details_cache[device]
drive_details = { drive_details = {
'model': None, 'model': None,
'serial': None, 'serial': None,
@@ -1127,6 +1133,7 @@ class SystemHealthMonitor:
except Exception as e: except Exception as e:
logger.debug(f"Error getting drive details for {device}: {e}") logger.debug(f"Error getting drive details for {device}: {e}")
self._drive_details_cache[device] = drive_details
return drive_details return drive_details