Redundant Drive Detail Calls #15

New Issue

2026-02-02T14:49:05-05:00

jared commented

2026-02-02 14:49:05 -05:00

_get_drive_details() is called multiple times for the same drive:

Line 1207 in ticket creation

Line 1418 in SMART check

Line 1286 in firmware check

Cache the results:

def init(self, ...):
# ...
self._drive_details_cache = {} # Add cache

def _get_drive_details(self, device: str) -> Dict[str, str]:
"""Get detailed drive information using smartctl (cached)."""
if device in self._drive_details_cache:
return self._drive_details_cache[device]

drive_details = {  # ... existing code ...  }

# Cache the result
self._drive_details_cache[device] = drive_details
return drive_details

_get_drive_details() is called multiple times for the same drive: Line 1207 in ticket creation Line 1418 in SMART check Line 1286 in firmware check Cache the results: def __init__(self, ...): # ... self._drive_details_cache = {} # Add cache def _get_drive_details(self, device: str) -> Dict[str, str]: """Get detailed drive information using smartctl (cached).""" if device in self._drive_details_cache: return self._drive_details_cache[device] drive_details = { # ... existing code ... } # Cache the result self._drive_details_cache[device] = drive_details return drive_details

jared referenced this issue from a commit

2026-02-10 13:22:34 -05:00

Cache drive details to eliminate redundant smartctl calls

jared closed this issue

2026-02-10 13:22:34 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/hwmonDaemon#15