Cancel in-flight diagnostic poll when user selects a new port

Previously switching ports while a diagnostic was running left the setInterval timer active, causing the result to be written into the old (now detached) DOM elements and never shown to the user. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix empty-object false negative in links page no-data check
2026-05-11 23:26:53 -04:00 · 2026-05-11 23:21:50 -04:00
2 changed files with 2 additions and 1 deletions
@@ -218,6 +218,7 @@ let _apiData        = null;
 function selectPort(el) {
  const swName = el.dataset.switch;
  const idx    = parseInt(el.dataset.portIdx, 10);
+  if (_diagPollTimer) { clearInterval(_diagPollTimer); _diagPollTimer = null; }
  document.querySelectorAll('.switch-port-block.selected')
    .forEach(e => e.classList.remove('selected'));
  el.classList.add('selected');
@@ -548,7 +548,7 @@ function checkLinksStale(updatedStr) {
 async function loadLinks() {
  try {
    const data = await lt.api.get('/api/links');
-    if (!data.hosts && !data.unifi_switches) {
+    if ((!data.hosts || !Object.keys(data.hosts).length) && (!data.unifi_switches || !Object.keys(data.unifi_switches).length)) {
      document.getElementById('links-container').innerHTML =
        '<div class="link-no-data">No link data yet — monitor has not completed a full cycle.</div>';
      return;
Author	SHA1	Message	Date
jared	2d6dcd782f	Cancel in-flight diagnostic poll when user selects a new port Lint / Python (flake8) (push) Successful in 45s Details Lint / JS (eslint) (push) Successful in 10s Details Security / Python Security (bandit) (push) Successful in 52s Details Test / Python Tests (pytest) (push) Successful in 1m2s Details Lint / Notify on failure (push) Has been skipped Details Lint / Deploy (push) Successful in 2s Details Previously switching ports while a diagnostic was running left the setInterval timer active, causing the result to be written into the old (now detached) DOM elements and never shown to the user. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-11 23:26:53 -04:00
jared	a1a3a52dd8	Fix empty-object false negative in links page no-data check Lint / Python (flake8) (push) Successful in 51s Details Lint / JS (eslint) (push) Successful in 10s Details Security / Python Security (bandit) (push) Successful in 46s Details Test / Python Tests (pytest) (push) Successful in 1m3s Details Lint / Notify on failure (push) Has been skipped Details Lint / Deploy (push) Successful in 3s Details The check `!data.hosts && !data.unifi_switches` never caught empty objects `{}`, which are truthy. Replace with Object.keys length checks so the friendly "no data yet" banner renders when both collections are empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-05-11 23:21:50 -04:00