CI / Build & Quality Checks (pull_request) Successful in 3m9s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 7s
CI / Playwright smoke (e2e) (pull_request) Successful in 12m36s
Lotus encodes DND as status_msg "dnd". After switching back to Auto, the heartbeat read the server's status, adopted "dnd" as the user's own and kept re-sending it, so the custom status was lost and other clients kept showing "dnd"; the Settings status field showed "dnd" too. pickHeartbeatStatus (unit-tested) never adopts the "dnd" sentinel and falls back to the device's real status; Profile neither mirrors it into the local status nor shows it in the field. Verified on the local Synapse: "🎮 Gaming" → DND (unavailable/dnd) → Auto → online/"🎮 Gaming" (before: online/"dnd"). Still open in #283: while in DND other clients show the literal "dnd"; that needs MSC3026 busy presence on the homeserver (matrix#19). Refs #283 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
52 lines
2.0 KiB
TypeScript
52 lines
2.0 KiB
TypeScript
/**
|
|
* Status messages are saved per device (`lotus-status-msg-<user>`) and
|
|
* re-sent with every presence heartbeat, because a presence write that omits
|
|
* `status_msg` clears it on Synapse. #187 DP3: a device never receives its own
|
|
* user's presence changes made on other devices, so a status cleared elsewhere
|
|
* stayed in its local copy and was re-published on the next heartbeat. The
|
|
* heartbeat now reconciles with the server first (see usePresenceUpdater); this
|
|
* module only tracks this device's own writes so that a fresh local save isn't
|
|
* overridden by a server read that hasn't caught up yet.
|
|
*/
|
|
|
|
/** The status_msg Lotus sends for Do Not Disturb (see usePresenceUpdater). */
|
|
export const DND_STATUS_SENTINEL = 'dnd';
|
|
|
|
/** Trust this device's own copy for this long after it saved or cleared it. */
|
|
export const LOCAL_WRITE_GRACE_MS = 15_000;
|
|
|
|
let lastLocalWriteAt = 0;
|
|
|
|
/** Call whenever this device saves or clears its own status. */
|
|
export const noteLocalStatusWrite = (now: number = Date.now()): void => {
|
|
lastLocalWriteAt = now;
|
|
};
|
|
|
|
export const getLastLocalStatusWrite = (): number => lastLocalWriteAt;
|
|
|
|
/**
|
|
* Which status a heartbeat should send, given what the server says now.
|
|
* `server` is undefined when the read failed. An offline server presence
|
|
* (invisible mode) carries an empty status by design, so it isn't a clear.
|
|
*/
|
|
export const pickHeartbeatStatus = ({
|
|
local,
|
|
server,
|
|
lastLocalWriteAt: writtenAt,
|
|
now,
|
|
}: {
|
|
local: string;
|
|
server: { presence: string; status_msg?: string } | undefined;
|
|
lastLocalWriteAt: number;
|
|
now: number;
|
|
}): string => {
|
|
// [Gitea #283] Lotus encodes Do Not Disturb as status_msg "dnd", so a device
|
|
// leaving DND must not adopt that sentinel as the user's status — keep (and
|
|
// so restore) the real one it holds locally.
|
|
const mine = local === DND_STATUS_SENTINEL ? '' : local;
|
|
if (!server || server.presence === 'offline') return mine;
|
|
if (now - writtenAt < LOCAL_WRITE_GRACE_MS) return mine;
|
|
if (server.status_msg === DND_STATUS_SENTINEL) return mine;
|
|
return server.status_msg ?? '';
|
|
};
|