LotusGuild/cinny
3
0
Fork 0
Code Issues 40 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(acl): a missing allow_ip_literals means allowed (#261) #426

Merged
jared merged 1 commits from fix/acl-ip-literals-default into lotus 2026-10-19 14:21:18 -04:00
Conversation 0 Commits 1 Files Changed 3
+76 -22
1 Commits
Author SHA1 Message Date
Lotus CIandClaude Opus 5.5 adf94d7bc1 fix(acl): a missing allow_ip_literals means allowed (#261)
CI / Build & Quality Checks (pull_request) Successful in 1m54s
Details
CI / Trigger Desktop Build (pull_request) Skipped
Details
CI / Docker image build & smoke test (pull_request) Skipped
Details
CI / Secret scan (gitleaks) (pull_request) Successful in 10s
Details
CI / Playwright smoke (e2e) (pull_request) Successful in 11m45s
Details 
The Server ACL editor treated an absent allow_ip_literals as false, so the
first save in a room with no ACL (or one omitting the field) silently banned
IP-literal servers. The spec default is true. normalizeServerAcl() fills the
spec defaults once and feeds the initial state, the dirty check and the save.
It also stops showing an existing ACL with no allow list as allow-all: per
spec that allows no servers, and the /acl command already keeps it as-is.

The checkbox is driven by onClick (folds has no onChange), now readOnly so
React stops warning about a checked input without onChange.

Fixes #261

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
 2026-10-19 14:07:03 -04:00