fix(dev): ML noise suppression works on npm start; no lotusTheme warning per call (#293) #410
Merged
jared
merged 1 commits from 2026-10-18 09:59:53 -04:00
fix/dev-denoise-theme into lotus
No Reviewers
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#410
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #293.
1. ML noise suppression didn't work on
npm start. The denoise worklets, wasm and models were only copied intodist/public/element-call/denoise/by thelotus-denoisecloseBundlehook. On the dev server the call frame got the SPA fallback (MIME type mismatch) and silently fell back to the raw mic.denoiseSources()shared by the build copy and a newconfigureServermiddleware. The middleware serves the same/public/element-call/denoise/…paths in dev, with JS/wasm content types.prefer-template).2.
lotusThemewarning in every call.getWidgetnow sendslotusTheme=truealong withlotusTransparent. The fork applied the theme anyway and loggedlotusTransparent is set without lotusThemeeach call.Verified on the dev server (
npx vite):rnnoiseWorklet.js,speexWorklet.js,noiseGateWorklet.js,workadventure/audio-worklet.jsanddeepfilternet/index.esm.jsreturn 200 text/javascript;rnnoise.wasmanddf_bg.wasmreturn 200 application/wasm. Before, they got the HTML fallback.[lotus] denoise processor active (rnnoise, floor=0.15), and no lotusTheme warning.Seen while testing (not changed here): the host doesn't handle the fork's
io.lotus.denoise_state("host did not ack"), so a silent ML fallback (#260) still isn't surfaced in the UI.tscclean · unit tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5