Clicking Translate could do nothing visible. If the message was already in the target language, or detection failed or was low-confidence, useMessageTranslation set skipped and switched itself back off: no chip, no "Translating…", no error.
Change: a manual Translate that has nothing to do now shows a short toast with the reason:
"This message is already in English." (uses the target language's name);
"Couldn't tell what language this message is in, so it wasn't translated."
"Translation isn't available" was already shown as the chip's error state. Auto-translate never gets here, because it only activates for detected, available pairs.
Verified (Chromium 153 with Translator/LanguageDetector; Translate on a message from Bob):
Before: nothing.
After: the toast shows. In headless Chromium the detector can't resolve a language, so this run covers the "couldn't tell" path; the "already in English" text is covered by the unit test.
Fixes #287.
Clicking **Translate** could do nothing visible. If the message was already in the target language, or detection failed or was low-confidence, `useMessageTranslation` set `skipped` and switched itself back off: no chip, no "Translating…", no error.
**Change:** a manual Translate that has nothing to do now shows a short toast with the reason:
- "This message is already in English." (uses the target language's name);
- "Couldn't tell what language this message is in, so it wasn't translated."
"Translation isn't available" was already shown as the chip's error state. Auto-translate never gets here, because it only activates for detected, available pairs.
**Verified** (Chromium 153 with Translator/LanguageDetector; Translate on a message from Bob):
- **Before:** nothing.
- **After:** the toast shows. In headless Chromium the detector can't resolve a language, so this run covers the "couldn't tell" path; the "already in English" text is covered by the unit test.
`tsc` clean · unit tests pass · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
When a message was already in the target language, or its language
could not be detected, Translate switched itself back off with no chip,
no "Translating…" and no error. Show a short toast instead: "This
message is already in English." or "Couldn't tell what language this
message is in, so it wasn't translated."
Fixes#287
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared
merged commit a02eda05cb into lotus2026-10-18 08:59:31 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #287.
Clicking Translate could do nothing visible. If the message was already in the target language, or detection failed or was low-confidence,
useMessageTranslationsetskippedand switched itself back off: no chip, no "Translating…", no error.Change: a manual Translate that has nothing to do now shows a short toast with the reason:
"Translation isn't available" was already shown as the chip's error state. Auto-translate never gets here, because it only activates for detected, available pairs.
Verified (Chromium 153 with Translator/LanguageDetector; Translate on a message from Bob):
tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5