LotusGuild/cinny
3
0
Fork 0
Code Issues 42 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(notifications): notification replies re-check encryption at send time and use the right account (#299) #397

Merged
jared merged 1 commits from fix/sw-reply-checks into lotus 2026-10-18 03:55:02 -04:00
Conversation 0 Commits 1 Files Changed 6
+133 -54
1 Commits
Author SHA1 Message Date
Lotus CIandClaude Opus 5.5 005fc9e768 fix(notifications): notification replies re-check encryption at send time and use the right account (#299)
CI / Build & Quality Checks (pull_request) Successful in 2m43s
Details
CI / Trigger Desktop Build (pull_request) Skipped
Details
CI / Docker image build & smoke test (pull_request) Skipped
Details
CI / Secret scan (gitleaks) (pull_request) Successful in 12s
Details
CI / Playwright smoke (e2e) (pull_request) Successful in 16m49s
Details 
The service worker posts inline notification replies in the clear (it
cannot encrypt). The Reply action was only withheld for rooms that were
encrypted when the notification was shown, so a reply typed hours later
into a room that has since turned on encryption went out unencrypted.
It also posted with the newest session the worker knew, not the
notification's account.

The worker now GETs the room's m.room.encryption state first and only
sends on a definite 404; notifications carry the user id and the worker
uses that account's session (or refuses). "Reply not sent" says why.

Fixes #299

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
 2026-10-17 20:52:12 -04:00