notify() shows an in-app toast while the window is focused, and falls back to an OS notification only when it isn't. But both message and invite notifications called it only when Notification.permission === 'granted'. Anyone who declined the browser prompt, or was never asked (most web users), heard the ping and saw nothing on screen.
Change: both call sites now notify when showNotifications is on and either the window is focused (in-app toast, no permission needed) or the permission is granted (OS notification).
Verified (Chromium, page focused in another room, Notification.permission = denied; Bob sends a DM):
Fixes #324.
`notify()` shows an **in-app toast** while the window is focused, and falls back to an OS notification only when it isn't. But both message and invite notifications called it only when `Notification.permission === 'granted'`. Anyone who declined the browser prompt, or was never asked (most web users), heard the ping and saw nothing on screen.
**Change:** both call sites now notify when `showNotifications` is on **and** either the window is focused (in-app toast, no permission needed) or the permission is granted (OS notification).
**Verified** (Chromium, page focused in another room, `Notification.permission = denied`; Bob sends a DM):
- **Before:** no toast.
- **After:** the toast shows the message.
`tsc` clean · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
notify() shows an in-page toast while the window is focused and only
falls back to an OS notification otherwise, but both message and invite
notifications were gated on Notification.permission === granted. Anyone
who declined (or was never asked) heard the ping with nothing on screen.
Gate only the OS path on the permission.
Fixes#324
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #324.
notify()shows an in-app toast while the window is focused, and falls back to an OS notification only when it isn't. But both message and invite notifications called it only whenNotification.permission === 'granted'. Anyone who declined the browser prompt, or was never asked (most web users), heard the ping and saw nothing on screen.Change: both call sites now notify when
showNotificationsis on and either the window is focused (in-app toast, no permission needed) or the permission is granted (OS notification).Verified (Chromium, page focused in another room,
Notification.permission = denied; Bob sends a DM):tscclean · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5