fix(status): any Lotus device clears an auto-expiring status, not just the one that set it (#300) #394
Open
jared
wants to merge 1 commits from
fix/status-expiry-account-data into lotus
pull from: fix/status-expiry-account-data
merge into: :lotus
:lotus
:fix/call-disconnected-bar
:fix/audio-output-frame-ids
:fix/close-no-tray
:fix/soundboard-not-permitted
:fix/pip-minimise
:fix/denoise-state-notice
:docs/features-catchup
:fix/desktop-settings-section
:fix/dev-denoise-theme
:fix/translate-unavailable-copy
:fix/pwa-manifest
:fix/translate-feedback
:fix/consent-retry-snooze
:fix/strip-metadata-packs
:fix/preview-deceptive-links
:fix/embed-ogurl-provider
:fix/settingtile-nesting
:fix/shortcuts-dialog
:fix/forward-encryption-warning
:fix/compress-alpha-anim
:fix/screenshare-double-toast
:fix/sw-reply-checks
:fix/pip-default-position
:fix/inapp-toast-permission
:fix/status-expiry-account-data
:fix/mute-timers-account-data
:fix/policy-dedupe
:fix/nudge-dismissed-strip
:fix/kuma-plain-text
:fix/rejoin-dm
:fix/search-edit-dupes
:fix/room-filter-empty
:fix/emoji-board-escape
:fix/call-failed-retry
:fix/share-links-lotus
:fix/poll-vote-local-echo
:fix/scheduled-from-server
:fix/delayed-restart-dedupe
:fix/decline-references-notification
:fix/stall-watchdog
:fix/filtered-timeline-double-count
:fix/call-listener-limit
:fix/voice-room-no-room-ping
:fix/reactions-collapse-loop
:fix/group-call-permission
:fix/dialog-enter-closes
:fix/delivery-status-live
:fix/room-upgrade-lotus-state
:fix/quiet-hours-tick
:fix/logout-wipe-leftovers
:fix/inter-font-name
:fix/retention-floor-grace
:fix/firefox-persist-hang
:fix/phantom-ring-after-reload
:fix/local-room-names-rest
:fix/missed-call-voice-rooms
:fix/animated-bg-compositor
:fix/link-safety-bypasses
:fix/e2e-register-403
:fix/local-room-names-everywhere
:fix/collapsible-messages
:fix/logout-volume-residue
:fix/enter-newline-device-local
:fix/dnd-restore-status
:fix/presence-sticky
:fix/location-confirm
:fix/reminders-stick
:fix/voice-full-distinct-users
:fix/presence-pagehide-status
:fix/gif-card-aspect
:deps/npm-audit-fixes
:security-nudge
:linux-package-updates
:audit-brace-expansion
:server-status-banner
:desktop-keychain-mirror
:desktop-call-origin
:clock-skew-lag
:offline-outbox
:desktop-lotus-links
:poll-ui
:calls-open-in-browser
:screenshare-prompt
:call-origin-split
:update-packages
:sw-fix
:read-me-update
:image-path-changes
:dm-calls
:fix-2469
:renovate/element-hq-element-call-embedded-0.x
:renovate/npm-i18next-http-backend-vulnerability
:renovate/npm-vite-vulnerability
:dev
:docs-update
:more-theme
:fix-257
:imporve-thread-reply
:revert-2402-improve-menu-congestion
:mxidColor-toggle
:update-sw-main-msg
No Reviewers
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#394
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #300.
"Auto-clear after 1 hour" stored the expiry only in the setting device's localStorage. A status like "🍔 Lunch" set on a laptop that was then closed stayed on the server (
presence.status_msg) until that laptop opened Lotus again. Other devices adopt the server status but never knew when it expired.Change
io.lotus.status_expiry, holding{ status_msg, expires_at }. Profile writes it with the status (save, presets) and removes it on Clear or a status without expiry. The local key stays as before.StatusExpiryMonitoron every device also checks the shared expiry:Verified (local Synapse): a status plus a 10 s expiry set by "device A" through the API, then only device B opened. Before expiry the status is
"🍔 Lunch 336". About 30 s later it is"", and the expiry record is{}.Unit tests for parsing and the clear / forget decision.
tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
"Clear after 1 hour" lived in that device's localStorage, so a status set on a laptop that was then closed stayed on the server until the laptop opened Lotus again. The expiry is now also kept in account data (io.lotus.status_expiry: { status_msg, expires_at }). Every device's StatusExpiryMonitor clears the status when due, but only if it is still the one that was set to expire (otherwise it just forgets the expiry). Fixes #300 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.