LotusGuild/cinny
3
0
Fork 0
Code Issues 113 Pull Requests 9 Actions Packages Projects Releases Wiki Activity

fix(messages): the delivery indicator updates when a send completes (#306) #374

Open
jared wants to merge 1 commits from fix/delivery-status-live into lotus
pull from: fix/delivery-status-live
merge into: :lotus
Conversation 0 Commits 1 Files Changed 1
+16 -1
jared commented 2026-10-16 22:25:45 -04:00
Owner
Copy Link
Copy Source

Fixes #306.

DeliveryStatus showed whatever mEvent.status was at the last timeline re-render. A local echo's status changes (SENDING → SENT → confirmed, NOT_SENT → retried) only emit event-level events, which nothing in the timeline listens to. So the last message in a quiet room kept "Sending...", or a stale "Failed to send. Click to retry" after an outbox retry, indefinitely.

Change: the indicator re-renders on MatrixEventEvent.Status and LocalEventIdReplaced.

Checks: tsc clean · unit tests 1341 pass · ESLint clean. Not browser-verified yet. The issue's repro (a delayed /send, then the last row's indicator) is the test to run before relying on this.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #306. `DeliveryStatus` showed whatever `mEvent.status` was at the last timeline re-render. A local echo's status changes (`SENDING → SENT → confirmed`, `NOT_SENT → retried`) only emit event-level events, which nothing in the timeline listens to. So the **last message in a quiet room kept "Sending..."**, or a stale "Failed to send. Click to retry" after an outbox retry, indefinitely. **Change:** the indicator re-renders on `MatrixEventEvent.Status` and `LocalEventIdReplaced`. **Checks:** `tsc` clean · unit tests 1341 pass · ESLint clean. **Not browser-verified yet.** The issue's repro (a delayed `/send`, then the last row's indicator) is the test to run before relying on this. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-16 22:25:46 -04:00
fix(messages): the delivery indicator updates when a send completes (#306)
CI / Build & Quality Checks (pull_request) Successful in 3m47s
Details
CI / Trigger Desktop Build (pull_request) Skipped
Details
CI / Docker image build & smoke test (pull_request) Skipped
Details
CI / Secret scan (gitleaks) (pull_request) Successful in 13s
Details
CI / Playwright smoke (e2e) (pull_request) Successful in 14m53s
Details
36e697613b 
DeliveryStatus showed whatever mEvent.status was at the last timeline
re-render, and a local echo's status changes (SENDING → SENT → confirmed,
NOT_SENT → retried) only emit event-level events, so the last message in
a quiet room kept "Sending..." (or a stale "Failed to send. Click to
retry" after an outbox retry) indefinitely. It now re-renders on
MatrixEventEvent.Status / LocalEventIdReplaced.

Not browser-verified in this change (checks: tsc, unit tests, eslint).

Fixes #306

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
All checks were successful
CI / Build & Quality Checks (pull_request) Successful in 3m47s
Details
CI / Trigger Desktop Build (pull_request) Skipped
Details
CI / Docker image build & smoke test (pull_request) Skipped
Details
CI / Secret scan (gitleaks) (pull_request) Successful in 13s
Details
CI / Playwright smoke (e2e) (pull_request) Successful in 14m53s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/delivery-status-live:fix/delivery-status-live
git checkout fix/delivery-status-live
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#374