fix(rooms): upgrading a room keeps its Lotus settings (#327) #373
Merged
jared
merged 1 commits from 2026-10-17 17:51:42 -04:00
fix/room-upgrade-lotus-state into lotus
No Reviewers
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#373
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #327.
POST /rooms/{id}/upgradecopies only Synapse's fixed list of state. An upgrade therefore silently dropped everything Lotus keeps in room state:Change:
RoomUpgradenow reads the client-owned state first and re-creates it in the replacement room. The list lives inutils/roomUpgradeState(unit-tested):io.lotus.*,m.room.retention, role tags and room emoji packs. A partial copy is reported in the dialog instead of closing silently.Verified headless through the UI, upgrading a v10 room that had a voice limit, a quality policy, a soundboard pack and retention:
Follow-up, not in this PR: for spaces, the children's
m.space.parentevents still point at the old space.tscclean · unit tests pass · ESLint/Prettier clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
POST /rooms/{id}/upgrade copies only Synapse's fixed list of state, so an upgrade silently dropped everything Lotus keeps in room state: an audio-only voice channel became camera/screenshare-allowed, user limits and bitrate caps vanished, the soundboard pack was lost, and a room set to delete messages after 7 days kept new ones forever. RoomUpgrade now reads the client-owned state first (utils/roomUpgradeState, unit-tested: io.lotus.*, m.room.retention, role tags, room emoji packs) and re-creates it in the replacement room; a partial copy is reported in the dialog instead of closing silently. Verified headless through the UI (v10 room with voice limit, quality policy, a soundboard pack and retention → upgrade): before, none survived; now all four are in the new room. Follow-up (not here): for spaces, the children's m.space.parent still point at the old space. Fixes #327 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5