LotusGuild/cinny

fix(timeline): media gallery / activity log no longer make the timeline drop messages (#259) #368

Merged

jared merged 3 commits from fix/filtered-timeline-double-count into lotus

2026-10-17 21:37:09 -04:00

Author	SHA1	Message	Date
jared	00e27a24e6	Merge branch 'lotus' into fix/filtered-timeline-double-count CI / Build & Quality Checks (pull_request) Successful in 2m44s Details CI / Trigger Desktop Build (pull_request) Skipped Details CI / Docker image build & smoke test (pull_request) Skipped Details CI / Secret scan (gitleaks) (pull_request) Successful in 7s Details CI / Playwright smoke (e2e) (pull_request) Successful in 18m21s Details	2026-10-17 19:08:38 -04:00
Lotus CI	d1270956ea	Merge remote-tracking branch 'origin/lotus' into fix/filtered-timeline-double-count CI / Secret scan (gitleaks) (pull_request) Successful in 29s Details CI / Build & Quality Checks (pull_request) Failing after 11m33s Details CI / Trigger Desktop Build (pull_request) Skipped Details CI / Docker image build & smoke test (pull_request) Skipped Details CI / Playwright smoke (e2e) (pull_request) Skipped Details # Conflicts: # src/app/components/CallEmbedProvider.tsx	2026-10-17 17:52:35 -04:00
Lotus CIandClaude Opus 5.5	5b5fbdb7b7	fix(timeline): media gallery / activity log no longer make the timeline drop messages (#259 ) CI / Build & Quality Checks (pull_request) Successful in 2m22s Details CI / Trigger Desktop Build (pull_request) Skipped Details CI / Docker image build & smoke test (pull_request) Skipped Details CI / Secret scan (gitleaks) (pull_request) Successful in 12s Details CI / Playwright smoke (e2e) (pull_request) Successful in 13m16s Details The media gallery and activity log register filtered timeline sets on the room (getOrCreateFilteredTimelineSet); the room re-emits their events as live RoomEvent.Timeline, so every matching event reached "new event in the room" listeners twice for the rest of the session. The timeline window shifted by an extra message per event (loaded messages vanished), and notifications, unread counts, widget feeds and ring handling saw duplicates. isFromFilteredTimelineSet() (unit-tested) identifies emits from a filtered set; the room timeline, roomToUnread, message notifications, clock-skew sampling, call ring/decline handling and widget event feeds ignore them. Verified headless (40 messages, every 5th a file; gallery opened; Bob sends 3 files + 1 text): before, the first rendered message drifted from the room start to "file15"; now it stays put. Fixes #259 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5	2026-10-16 21:42:47 -04:00