fix(calls): no "Missed call" in voice rooms or space channels #363

2026-10-16T20:29:57-04:00

jared commented

2026-10-16 20:29:57 -04:00

Joining a voice channel alone sends a call notification (m.rtc.notification) to the room. The timeline rendered every unanswered one as "Missed call from X", so everyone in the channel saw a missed call from someone who had only joined it. Ringing already excluded these rooms; the missed-call line didn't.

Change: utils/callRing.ts (3 unit tests) now holds the one rule for both ringing and the missed-call line:

DMs and invite-only groups outside any space ring and can show "Missed call";
voice rooms, space channels, and restricted or public rooms never do.

Verified headless with the same two notifications from Bob:

room	before	after
Voice Lounge (voice room in a space), chat panel	2 "Missed call" lines	0
small invite-only group	1	1

tsc clean · unit tests pass · ESLint/Prettier clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Joining a voice channel alone sends a call notification (`m.rtc.notification`) to the room. The timeline rendered every unanswered one as **"Missed call from X"**, so everyone in the channel saw a missed call from someone who had only joined it. Ringing already excluded these rooms; the missed-call line didn't. **Change:** `utils/callRing.ts` (3 unit tests) now holds the one rule for both ringing and the missed-call line: - **DMs** and **invite-only groups outside any space** ring and can show "Missed call"; - **voice rooms**, **space channels**, and **restricted or public rooms** never do. **Verified** headless with the same two notifications from Bob: | room | before | after | |---|---|---| | Voice Lounge (voice room in a space), chat panel | **2** "Missed call" lines | **0** | | small invite-only group | 1 | 1 | `tsc` clean · unit tests pass · ESLint/Prettier clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

jared added 1 commit 2026-10-16 20:29:57 -04:00

fix(calls): no "Missed call" in voice rooms or space channels

CI / Build & Quality Checks (pull_request) Successful in 1m39s

Details

CI / Trigger Desktop Build (pull_request) Skipped

Details

CI / Docker image build & smoke test (pull_request) Skipped

Details

CI / Secret scan (gitleaks) (pull_request) Successful in 7s

Details

CI / Playwright smoke (e2e) (pull_request) Successful in 10m48s

Details

4650796120

Joining a voice channel alone sends a call notification (m.rtc.notification)
to the room, and the timeline rendered every unanswered one as "Missed call
from X", so everyone in the channel saw a missed call from someone who had
just joined it. Ringing already excluded these rooms; the missed-call line
didn't.

utils/callRing.ts (unit-tested) holds the one rule for both: only DMs and
invite-only groups outside any space ring or show "Missed call"; voice
rooms, space channels, restricted and public rooms don't.

Verified headless with the same two notifications from Bob: the Voice
Lounge chat showed 2 "Missed call" lines before, 0 after; a small
invite-only group still shows its missed call.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

jared merged commit 400ee76b63 into lotus

2026-10-16 21:06:57 -04:00

jared referenced this pull request

2026-10-16 21:12:15 -04:00

Client audit 2026-10: tracking index #281

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/cinny#363