fix(presence): closing a tab no longer erases your custom status (#339) #350
Merged
jared
merged 1 commits from 2026-10-11 22:57:25 -04:00
fix/presence-pagehide-status into lotus
No Reviewers
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#350
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #339.
The
pagehidekeepalive write sent{"presence":"offline"}with nostatus_msg. Synapse treats a missingstatus_msgas clearing it, so closing or reloading any Lotus tab wiped the user's custom status for everyone. It happened intermittently, because the 10 s presence rate limit sometimes rejected the write. It now sends the current status with the offline state.Verified on the local Synapse, with the status set from another device:
online/ Gone fishingonline/ Gone fishingoffline/ Gone fishingThe close-time body is now
{"presence":"offline","status_msg":"Gone fishing"}.tscclean · unit tests 1325 pass · ESLint/Prettier clean on the changed file.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
The pagehide keepalive write sent { presence: 'offline' } with no status_msg, which Synapse treats as clearing it, so closing or reloading any Lotus tab wiped the user's status for everyone (intermittently, as the 10 s presence rate limit sometimes 429'd the write). It now sends the current status along with the offline state. Verified against the local Synapse: with a status set from another device, two reloads and a tab close keep it (server shows offline/"Gone fishing" after the close; before, the first reload wiped it). Fixes #339 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5