Read me update #2

Re-reviewed at head 6a0037ec. The nvm / .node-version walkthrough is a genuinely useful addition — that Node-setup detail wasn't spelled out anywhere. Two things before it can land:

It's stacked on the image-path commit (2bbd390a), which fails CI. This branch carries the older image-path change (from before you fixed the formatting on #1), so npm run check:prettier and npm run lint
fail on the source files (import/newline-after-import on the logo consts + the prettier spacing). Rebase onto current lotus and drop the image-path commit so this PR is only the README change — then the
gates go green. (The README itself is prettier-clean. 👍)
Duplicate section. lotus already has a "Local Development" section under For Developers (from f12e05c5) covering npm ci / npm start / port 8080 / homeserver login. This adds a second dev-setup section
near the top of the README. Please fold the nvm/Node-version steps into the existing section instead of creating a parallel one.

(Minor: the new headings jump ## → #### → ###; worth keeping them consistently nested.)

Re-reviewed at head 6a0037ec. The nvm / .node-version walkthrough is a genuinely useful addition — that Node-setup detail wasn't spelled out anywhere. Two things before it can land: 1. It's stacked on the image-path commit (2bbd390a), which fails CI. This branch carries the older image-path change (from before you fixed the formatting on #1), so npm run check:prettier and npm run lint fail on the source files (import/newline-after-import on the logo consts + the prettier spacing). Rebase onto current lotus and drop the image-path commit so this PR is only the README change — then the gates go green. (The README itself is prettier-clean. 👍) 2. Duplicate section. lotus already has a "Local Development" section under For Developers (from f12e05c5) covering npm ci / npm start / port 8080 / homeserver login. This adds a second dev-setup section near the top of the README. Please fold the nvm/Node-version steps into the existing section instead of creating a parallel one. (Minor: the new headings jump ## → #### → ###; worth keeping them consistently nested.)

👎 1

jared requested review from jared 2026-08-02 19:44:07 -04:00

nathan added 3 commits 2026-08-02 20:05:07 -04:00

fixed retarded linter problem

CI / Build & Quality Checks (pull_request) Failing after 6m2s

Details

CI / Trigger Desktop Build (pull_request) Skipped

Details

b2376513fd

fixed retarded prettier 'error'

CI / Build & Quality Checks (pull_request) Successful in 10m45s

Details

CI / Trigger Desktop Build (pull_request) Skipped

Details

0aef410f60

Merge remote-tracking branch 'origin/image-path-changes' into read-me-update

CI / Build & Quality Checks (pull_request) Successful in 10m48s

Details

CI / Trigger Desktop Build (pull_request) Skipped

Details

f136082181

nathan added 1 commit 2026-08-02 20:29:11 -04:00

Merge remote-tracking branch 'origin/lotus' into read-me-update

CI / Trigger Desktop Build (pull_request) Skipped

Details

CI / Build & Quality Checks (pull_request) Failing after 4m59s

Details

6d9ee10926

nathan closed this pull request

2026-08-02 20:40:49 -04:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/cinny#2