fix(calls): the call-bar output menu uses the call frame's devices (#310) #417
Merged
jared
merged 4 commits from 2026-10-19 01:13:20 -04:00
fix/audio-output-frame-ids into lotus
No Reviewers
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#417
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #310 (with element-call#49, released as 0.25.0-lotus.24 and pinned here).
The call-bar audio output menu listed the chat page's devices, but browsers hash
deviceIdper frame/origin, so those ids mean nothing inside the call iframe. Picking "Headset" saved an unknown id in Element Call, which fell back to the default output, while the menu showed a ✓ on the device you picked.Change
CallControlhandles the fork'sio.lotus.audio_output_state { deviceId, available: [{id, label}] }, which also silences the fork's "host did not ack" log on every change. A unit-testedparseAudioOutputStatedoes the parsing.AudioOutputButtonbuilds the menu from the fork's list and effective selection. With older forks it falls back to the old list.@lotusguild/element-call-embedded@0.25.0-lotus.24.Verified with the published lotus.24 (Chromium fake devices):
This also covers the audio-output half of #260.
tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5