fix(translate): no "use the Lotus desktop app" advice inside the desktop app (#349) #409

Merged
jared merged 3 commits from fix/translate-unavailable-copy into lotus 2026-10-19 00:47:26 -04:00
Owner

Fixes #349.

Where Chromium's on-device Translator / LanguageDetector APIs are missing, Settings → General said: "Use a Chromium desktop browser (Chrome/Edge 138+) or the Lotus desktop app." The Linux and macOS desktop apps (WebKitGTK / WKWebView) lack those APIs too, so they showed this advice to people already in the app.

Change: new translationUnavailableText(desktopApp), picked with isTauri():

  • Desktop app: "On-device translation isn't available in this version of the desktop app. It works in Chrome or Edge 138+ on a computer."
  • Web: "On-device translation isn't available in this browser. Use Chrome or Edge 138+ on a computer."

The per-message Translate action was already hidden where the engine is unsupported (Message.tsx), so there's no dead end there. Windows (WebView2) isn't special-cased: where it has the APIs, this text never shows.

Unit test for both texts. No browser run, since this is a text change. tsc clean · ESLint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

Fixes #349. Where Chromium's on-device Translator / LanguageDetector APIs are missing, Settings → General said: "Use a Chromium desktop browser (Chrome/Edge 138+) **or the Lotus desktop app.**" The Linux and macOS desktop apps (WebKitGTK / WKWebView) lack those APIs too, so they showed this advice to people already in the app. **Change:** new `translationUnavailableText(desktopApp)`, picked with `isTauri()`: - **Desktop app:** "On-device translation isn't available in this version of the desktop app. It works in Chrome or Edge 138+ on a computer." - **Web:** "On-device translation isn't available in this browser. Use Chrome or Edge 138+ on a computer." The per-message **Translate** action was already hidden where the engine is unsupported (`Message.tsx`), so there's no dead end there. Windows (WebView2) isn't special-cased: where it has the APIs, this text never shows. Unit test for both texts. No browser run, since this is a text change. `tsc` clean · ESLint clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-18 00:19:53 -04:00
fix(translate): no "use the Lotus desktop app" advice inside the desktop app (#349)
CI / Build & Quality Checks (pull_request) Successful in 3m24s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 16s
CI / Playwright smoke (e2e) (pull_request) Failing after 18m15s
f41de57893
Where the on-device Translator/LanguageDetector APIs are missing,
Settings said to use Chrome/Edge "or the Lotus desktop app", but the
Linux and macOS apps (WebKit) lack them too, and showed the advice to
people already in the app. Word it by platform. (The per-message
Translate action was already hidden where unsupported.)

Fixes #349

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared added 1 commit 2026-10-18 23:38:14 -04:00
Merge remote-tracking branch 'origin/lotus' into fix/translate-unavailable-copy
CI / Build & Quality Checks (pull_request) Canceled after 0s
CI / Trigger Desktop Build (pull_request) Canceled after 0s
CI / Secret scan (gitleaks) (pull_request) Canceled after 0s
CI / Docker image build & smoke test (pull_request) Canceled after 0s
CI / Playwright smoke (e2e) (pull_request) Canceled after 0s
b07eb35159
# Conflicts:
#	src/app/utils/translation/langUtils.ts
jared added 1 commit 2026-10-18 23:40:47 -04:00
Merge branch 'lotus' into fix/translate-unavailable-copy
CI / Build & Quality Checks (pull_request) Successful in 1m50s
CI / Trigger Desktop Build (pull_request) Skipped
CI / Docker image build & smoke test (pull_request) Skipped
CI / Secret scan (gitleaks) (pull_request) Successful in 8s
CI / Playwright smoke (e2e) (pull_request) Successful in 12m19s
ca284a75e3
jared merged commit a20accd446 into lotus 2026-10-19 00:47:26 -04:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#409