Read me update #2
Closed
nathan
wants to merge 6 commits from
read-me-update into lotus
pull from: read-me-update
merge into: :lotus
:lotus
:update-packages
:sw-fix
:read-me-update
:image-path-changes
:dm-calls
:fix-2469
:renovate/element-hq-element-call-embedded-0.x
:renovate/npm-i18next-http-backend-vulnerability
:renovate/npm-vite-vulnerability
:dev
:docs-update
:more-theme
:fix-257
:imporve-thread-reply
:revert-2402-improve-menu-congestion
:mxidColor-toggle
:update-sw-main-msg
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#2
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Updated read me to include instructions for starting development server
Re-reviewed at head
6a0037ec. The nvm / .node-version walkthrough is a genuinely useful addition — that Node-setup detail wasn't spelled out anywhere. Two things before it can land:It's stacked on the image-path commit (
2bbd390a), which fails CI. This branch carries the older image-path change (from before you fixed the formatting on #1), so npm run check:prettier and npm run lintfail on the source files (import/newline-after-import on the logo consts + the prettier spacing). Rebase onto current lotus and drop the image-path commit so this PR is only the README change — then the
gates go green. (The README itself is prettier-clean. 👍)
Duplicate section. lotus already has a "Local Development" section under For Developers (from
f12e05c5) covering npm ci / npm start / port 8080 / homeserver login. This adds a second dev-setup sectionnear the top of the README. Please fold the nvm/Node-version steps into the existing section instead of creating a parallel one.
(Minor: the new headings jump ## → #### → ###; worth keeping them consistently nested.)
Pull request closed