fix(dev): ML noise suppression works on npm start; no lotusTheme warning per call (#293)

The denoise worklets/wasm/models were only copied into dist/ by the
lotus-denoise closeBundle hook, so on the dev server the call frame got
the SPA fallback for them and silently used the raw mic. The asset list
is now shared (denoiseSources) between that copy and a dev-server
middleware serving the same paths. Also send lotusTheme=true with
lotusTransparent, which the fork warned about in every call.

Fixes #293

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5

LOTUS_FEATURES.md

@@ -1,7 +1,7 @@
 # Lotus Chat — Feature Reference
 
 Everything added to Lotus Chat beyond upstream Cinny v4.12.1.
-Last updated: October 2026.
+Last updated: July 2026.
 
 ---
 
@@ -28,8 +28,7 @@ Last updated: October 2026.
 19. [Infrastructure](#infrastructure)
 20. [Localization](#localization)
 21. [Desktop App Features](#desktop-app-features)
-22. [June–October 2026 Additions](#juneoctober-2026-additions)
-23. [Key Custom Files](#key-custom-files)
+22. [Key Custom Files](#key-custom-files)
 
 ---
 
@@ -1523,98 +1522,6 @@ Checks for a new desktop release every 12h and offers a one-click update. `Tauri
 
 ---
 
-## June–October 2026 Additions
-
-Features shipped since the sections above were last updated (Gitea #294). Each
-line names the commit that introduced it.
-
-### Calls
-
-- **Selectable ringtone + volume:** pick the incoming-call ringtone (`4a875884`).
-- **In-call incoming-call banner:** a small banner for a second call instead of a full ring (`c67aed01`).
-- **Denoise tester:** Settings → Calls lets you audition the ML models and calibrate the noise gate (`14cfa021`).
-- **Mic level meter** on the mute button (`3449338b`, #146).
-- **"You're muted" nudge** when you talk into a muted mic (`73b1d1e3`, #117).
-- **Undeafen catch-up toast:** what you missed while deafened (`33e16e85`, #128).
-- **Admin turned off screen share / camera:** a toast explains why your share or camera stopped (`34574178`, #223).
-- **Voice-limit / audio-only chip** in the room header (`7f17940d`, #134).
-- **"N Live" pill names** who is in the call on hover / focus (`a475531b`, #157).
-- **Live-call dot on the space rail** (`4fe9c870`, #148).
-- **Missed-call line** in the timeline for DMs and small groups (`c921f115`, #162).
-- **Answer with camera or audio-only:** answering says when it turns the camera on (`d2f56817`, #135).
-- **Audio output quick-switch** in the call bar (`98c80f36`, #119).
-- **Call-ended summary toast:** "Call ended · 41 min · connection was good" (`af1c0ee1`, #143).
-- **No WebRTC on desktop:** offers "Open in browser" instead of a dead end (`fff583fc`).
-- **Call page on its own origin** (desktop, opt-in) (`7d7a379c`, #43).
-
-### Messaging & composer
-
-- **Reactions collapse** to one row with a +N chip (`bf05751e`, #138).
-- **Consecutive photos / videos** render as one gallery grid (`bd8c79e0`, #137).
-- **Inline audio playback** for `m.file` audio attachments (`eb34b047`).
-- **Recently used GIFs** in the GIF picker (`5b58e5fe`).
-- **Pasted image → caption field:** a single pasted or dropped image lands in its caption (`0c45bde8`, #129).
-- **Offer to format pasted code** as a code block (`75d55e86`, #107).
-- **Tap to preview stickers / GIFs** on touch, tap again to send (`8d11a62e`, #147).
-- **Link-mismatch confirmation** before opening a link whose text names another site (`74d8e311`, #122).
-- **Embed fallback** for hung embeds and deleted X posts (`ba5b1ffe`, #200).
-- **"Back to where you were"** after jumping in the timeline (`7da91bd8`, #127).
-- **Offline outbox:** unsent messages survive a reload and retry (`02d86cae`, #112).
-- **Terms-consent explanation** when "Failed to send" is the server wanting its terms accepted (`c96c47dd`).
-
-### Search & navigation
-
-- **Quick switcher (Ctrl/⌘+K)**, with a configurable key (`9d4679d2`).
-- **Search filters:** `has:image/file/video`, recent searches, pinned only (`1ee0f0b5`).
-- **Search operators:** `in:`, `before:` / `after:`, `has:`, `is:pinned` (`75951f90`, #106).
-- **Explore:** featured Lotus Guild space and the matrixrooms.info directory (`b1ecb0c4`).
-
-### Rooms & threads
-
-- **Disappearing messages** (MSC1763 `m.room.retention`) (`82e52e1b`).
-- **Mark as Unread** (MSC2867) and **Low Priority** rooms (`d46b91b1`).
-- **"Who can see this"** line under the room name in Room Settings (`ad1cbcf7`, #133).
-- **Threads: Mark all read** in the threads list (`fdec3ed7`, #165).
-
-### Media viewer
-
-- **Swipe** between items in the full-screen viewer (`cf80729a`, #164).
-- **Two-finger pinch zoom** (`39589b40`, #164).
-
-### Profile, privacy & safety
-
-- **Report User** (MSC4260) (`26f90087`).
-- **Active now / Last active** from presence (`dea1f7af`, #150).
-- **Delete all my messages** in a room (`edb46247`, #169).
-- **Self-hosted VT323 font** instead of Google Fonts (`6f250353`, #214).
-- **Device-security nudge:** verify this device / set up key backup (`6a7627fa`, #110, #123).
-- **Homeserver status banner** from Uptime Kuma (`6ae00872`, #124).
-
-### Appearance
-
-- **Custom accent colour** for non-TDS themes (`3c4842df`, P5-1).
-- **Theme presets:** Cyberpunk, Ocean, Blood Red, Matrix, Midnight (`65e24bd4`, P5-2).
-
-### Mobile & PWA
-
-- **Saved Messages** from the room header's More Options menu (`8c711f5f`).
-- **Long-press bottom sheet** of message actions (`53a80adb`, #166).
-- **Haptics** on PTT press / release and on reactions (`492b57c6`, #125).
-- **Android share target:** share into Lotus Chat from other apps (`96a97a2f`, #155).
-
-### Notifications
-
-- **Inline reply** from a browser notification (unencrypted rooms) (`d4420905`, #203).
-
-### Desktop app
-
-- **Tray icon mirrors call state** (`25fa0f6e`, cinny-desktop #4).
-- **Start minimized** under Launch on login (`4a982389`, cinny-desktop #3).
-- **First-close choice:** asks once what closing the window should do (`359c79a4`, cinny-desktop #5).
-- **Keychain mirror:** login tokens also kept in the OS keychain (`9b9f33b2`, #105).
-
----
-
 ## Key Custom Files
 
 | File                                                           | Purpose                                                                                     |

LOTUS_REFERENCE.md

@@ -34,7 +34,7 @@ This file keeps only what a contributor needs to have open while working: the tw
 
 ## 🚫 Blocked Features (server / upstream gated)
 
-Re-run `/_matrix/client/versions` + `unstable_features` after each Synapse upgrade. **Re-checked on 1.162.0 (2026-10-18, Gitea #294):** live location (`msc3489`/`msc3672`) and relation redaction (`msc3892`) are still unadvertised; thread subscriptions (`msc4306`), sticky events (`msc4354`) and QR login (`msc4108`) are still `false`. New: `org.matrix.msc3026.busy_presence` is advertised as `false`, and enabling it would give Do Not Disturb a real presence state (#283). `msc3266` and `msc4222` are no longer listed, but room preview still works (`im.nheko.summary` and `v1/room_summary` both answer 200). (Previous check: 1.157.1 on 2026-07-23, no change then.)
+Re-run `/_matrix/client/versions` + `unstable_features` after each Synapse upgrade. **Re-checked on 1.157.1 (2026-07-23): no change — all four below are still `false`.** The 1.156.0→1.157.1 delta unblocked nothing (it's a bugfix release; the only feature-bearing release in the gap was 1.156.0, which we were already running).
 
 - **[BLOCKED] Live Location Sharing** (MSC3489 + MSC3672 both `false`) — real-time GPS beacons over the existing static share.
 - **[BLOCKED] Reaction/Relation Redaction** (MSC3892 `false`) — remove a reaction without redacting the parent; current full-redaction fallback is acceptable.

src/app/plugins/call/CallEmbed.ts

@@ -218,6 +218,9 @@ export class CallEmbed {
       //  - transparent background so the room wallpaper shows through natively
       lotusCallState: 'true',
       lotusTransparent: 'true',
+      // [Gitea #293] the fork applies the theme with transparency anyway, and
+      // warned in every call that lotusTheme wasn't set
+      lotusTheme: 'true',
       // [Gitea #43] The fork hides its own footer (we draw the call bar) and
       // sets its root color-scheme from the theme, instead of us injecting CSS.
       lotusHostControls: 'true',

vite.config.js

@@ -87,97 +87,106 @@ function copyPdfWorker() {
   };
 }
 
-// Lotus ML noise suppression: ship the RNNoise worklet/wasm + our getUserMedia
-// shim alongside the vendored Element Call bundle, and inject the shim <script>
-// into EC's index.html so it runs before EC captures the mic. Runs after
-// viteStaticCopy has populated dist/public/element-call (closeBundle order).
+// The denoise assets the fork loads from ./denoise/ at runtime, as
+// [source, path under denoise/] pairs; `dir: true` entries are whole trees.
+// Shared by the build copy and the dev server (Gitea #293).
+function denoiseSources() {
+  const sapphi = path.resolve('node_modules/@sapphi-red/web-noise-suppressor/dist');
+  const dfnVendor = path.resolve('build/denoise-vendor/deepfilternet');
+  return {
+    // All bundled denoise assets are REQUIRED: every entry backs a model the
+    // UI can select (RNNoise, Speex) or the optional noise gate.
+    sapphi: [
+      [path.join(sapphi, 'rnnoise/workletProcessor.js'), 'rnnoiseWorklet.js'],
+      [path.join(sapphi, 'rnnoise.wasm'), 'rnnoise.wasm'],
+      [path.join(sapphi, 'rnnoise_simd.wasm'), 'rnnoise_simd.wasm'],
+      [path.join(sapphi, 'speex/workletProcessor.js'), 'speexWorklet.js'],
+      [path.join(sapphi, 'speex.wasm'), 'speex.wasm'],
+      [path.join(sapphi, 'noiseGate/workletProcessor.js'), 'noiseGateWorklet.js'],
+    ],
+    // DTLN (@workadventure/noise-suppression): a self-contained ES module that
+    // resolves its own worklet, LiteRT WASM runtime and TFLite models via
+    // `import.meta.url`, so its whole dist/ tree is served intact.
+    dtln: [path.resolve('node_modules/@workadventure/noise-suppression/dist'), 'workadventure'],
+    // DeepFilterNet 3: the ESM (worklet inlined) plus the vendored wasm and ONNX
+    // model (CDN-free / Tauri-CSP safe), in the package's expected v2/ layout.
+    dfn: [
+      [
+        path.resolve('node_modules/deepfilternet3-noise-filter/dist/index.esm.js'),
+        'deepfilternet/index.esm.js',
+      ],
+      [path.join(dfnVendor, 'v2/pkg/df_bg.wasm'), 'deepfilternet/v2/pkg/df_bg.wasm'],
+      [
+        path.join(dfnVendor, 'v2/models/DeepFilterNet3_onnx.tar.gz'),
+        'deepfilternet/v2/models/DeepFilterNet3_onnx.tar.gz',
+      ],
+    ],
+  };
+}
+
+// Lotus ML noise suppression: ship the denoise worklets/wasm/models alongside
+// the vendored Element Call bundle. Runs after viteStaticCopy has populated
+// dist/public/element-call (closeBundle order). [Gitea #293] The dev server
+// serves the same files at the same URLs, so `npm start` can test denoise.
 function lotusDenoise() {
+  const DEV_PREFIX = '/public/element-call/denoise/';
   return {
     name: 'lotus-denoise',
+    configureServer(server) {
+      const { sapphi, dtln, dfn } = denoiseSources();
+      const files = new Map([...sapphi, ...dfn].map(([src, rel]) => [rel, src]));
+      const types = { '.js': 'text/javascript', '.wasm': 'application/wasm' };
+      server.middlewares.use((req, res, next) => {
+        const url = (req.url ?? '').split('?')[0];
+        if (!url.startsWith(DEV_PREFIX)) return next();
+        const rel = decodeURIComponent(url.slice(DEV_PREFIX.length));
+        let file = files.get(rel);
+        if (!file && rel.startsWith(`${dtln[1]}/`)) {
+          const candidate = path.resolve(dtln[0], rel.slice(dtln[1].length + 1));
+          if (candidate.startsWith(dtln[0] + path.sep)) file = candidate;
+        }
+        if (!file || !fs.existsSync(file)) return next();
+        res.setHeader('Content-Type', types[path.extname(file)] ?? 'application/octet-stream');
+        fs.createReadStream(file).pipe(res);
+        return undefined;
+      });
+    },
     closeBundle() {
       const ecDir = path.resolve('dist/public/element-call');
       if (!fs.existsSync(ecDir)) return;
 
       const denoiseDir = path.join(ecDir, 'denoise');
       fs.mkdirSync(denoiseDir, { recursive: true });
+      const { sapphi, dtln, dfn } = denoiseSources();
 
-      const sapphi = path.resolve('node_modules/@sapphi-red/web-noise-suppressor/dist');
-      // All bundled denoise assets are REQUIRED: every entry backs a model the
-      // UI can select (RNNoise, Speex) or the optional noise gate. A missing
-      // source means a partial/changed install would otherwise silently ship a
-      // broken ML feature (worklet 404 -> raw mic), so we fail the build instead.
-      const assets = [
-        [
-          path.join(sapphi, 'rnnoise/workletProcessor.js'),
-          path.join(denoiseDir, 'rnnoiseWorklet.js'),
-        ],
-        [path.join(sapphi, 'rnnoise.wasm'), path.join(denoiseDir, 'rnnoise.wasm')],
-        [path.join(sapphi, 'rnnoise_simd.wasm'), path.join(denoiseDir, 'rnnoise_simd.wasm')],
-        [path.join(sapphi, 'speex/workletProcessor.js'), path.join(denoiseDir, 'speexWorklet.js')],
-        [path.join(sapphi, 'speex.wasm'), path.join(denoiseDir, 'speex.wasm')],
-        [
-          path.join(sapphi, 'noiseGate/workletProcessor.js'),
-          path.join(denoiseDir, 'noiseGateWorklet.js'),
-        ],
-      ];
-      const missing = assets.filter(([s]) => !fs.existsSync(s)).map(([s]) => s);
+      // A missing source means a partial/changed install would otherwise
+      // silently ship a broken ML feature (worklet 404 -> raw mic), so we fail
+      // the build instead.
+      const missing = sapphi.filter(([s]) => !fs.existsSync(s)).map(([s]) => s);
       if (missing.length > 0) {
         throw new Error(
           `[lotus-denoise] Required denoise asset(s) missing — build aborted to avoid shipping a broken ML feature:\n  ${missing.join('\n  ')}`,
         );
       }
-      assets.forEach(([s, d]) => fs.copyFileSync(s, d));
+      sapphi.forEach(([s, rel]) => fs.copyFileSync(s, path.join(denoiseDir, rel)));
 
-      // DTLN (@workadventure/noise-suppression): unlike the flat sapphi
-      // worklets, this package is a self-contained ES module that resolves its
-      // own AudioWorklet processor, LiteRT WASM runtime and TFLite models via
-      // `import.meta.url`. So we copy its whole dist/ tree intact to
-      // denoise/workadventure/ (preserving assets/ + vendor/) and let the shim
-      // dynamic-import denoise/workadventure/audio-worklet.js at runtime. The
-      // entry module is required — fail the build if the install is broken.
-      const dtlnSrc = path.resolve('node_modules/@workadventure/noise-suppression/dist');
-      const dtlnEntry = path.join(dtlnSrc, 'audio-worklet.js');
+      const dtlnEntry = path.join(dtln[0], 'audio-worklet.js');
       if (!fs.existsSync(dtlnEntry)) {
         throw new Error(
           `[lotus-denoise] DTLN entry missing (${dtlnEntry}) — build aborted. ` +
             'Run `npm ci` to install @workadventure/noise-suppression.',
         );
       }
-      fs.cpSync(dtlnSrc, path.join(denoiseDir, 'workadventure'), { recursive: true });
+      fs.cpSync(dtln[0], path.join(denoiseDir, dtln[1]), { recursive: true });
 
-      // DeepFilterNet 3 (deepfilternet3-noise-filter): the npm package ships only
-      // its ESM (index.esm.js) with the AudioWorklet processor + wasm-bindgen glue
-      // INLINED as a string (loaded via a Blob URL, no CDN for the worklet). The
-      // only runtime CDN fetches are its single-threaded `df_bg.wasm` and the
-      // ONNX `DeepFilterNet3_onnx.tar.gz` model — which we VENDOR locally (under
-      // build/denoise-vendor/deepfilternet/) and serve, overriding the package's
-      // cdnUrl to our self-hosted base. This keeps the feature CDN-free / Tauri-CSP
-      // safe. We copy the ESM (the shim dynamic-imports it, mirroring DTLN) plus
-      // the vendored assets, preserving the package's expected v2/... layout. All
-      // are required — a missing entry means a broken install, so fail the build.
-      const dfnEsm = path.resolve('node_modules/deepfilternet3-noise-filter/dist/index.esm.js');
-      const dfnVendor = path.resolve('build/denoise-vendor/deepfilternet');
-      const dfnAssets = [
-        [dfnEsm, path.join(denoiseDir, 'deepfilternet/index.esm.js')],
-        [
-          path.join(dfnVendor, 'v2/pkg/df_bg.wasm'),
-          path.join(denoiseDir, 'deepfilternet/v2/pkg/df_bg.wasm'),
-        ],
-        [
-          path.join(dfnVendor, 'v2/models/DeepFilterNet3_onnx.tar.gz'),
-          path.join(denoiseDir, 'deepfilternet/v2/models/DeepFilterNet3_onnx.tar.gz'),
-        ],
-      ];
-      const dfnMissing = dfnAssets.filter(([s]) => !fs.existsSync(s)).map(([s]) => s);
+      const dfnMissing = dfn.filter(([s]) => !fs.existsSync(s)).map(([s]) => s);
       if (dfnMissing.length > 0) {
         throw new Error(
-          '[lotus-denoise] DeepFilterNet 3 asset(s) missing — build aborted to avoid ' +
-            'shipping a broken ML feature:\n  ' +
-            dfnMissing.join('\n  ') +
-            '\n(Run `npm ci`; the vendored wasm/model live under build/denoise-vendor/deepfilternet/.)',
+          `[lotus-denoise] DeepFilterNet 3 asset(s) missing — build aborted to avoid shipping a broken ML feature:\n  ${dfnMissing.join('\n  ')}\n(Run \`npm ci\`; the vendored wasm/model live under build/denoise-vendor/deepfilternet/.)`,
         );
       }
-      dfnAssets.forEach(([s, d]) => {
+      dfn.forEach(([s, rel]) => {
+        const d = path.join(denoiseDir, rel);
         fs.mkdirSync(path.dirname(d), { recursive: true });
         fs.copyFileSync(s, d);
       });