LotusGuild/cinny
3
0
Fork 0
Code Issues 39 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(notifications): in-app toasts no longer need browser notification permission (#324)' (#395) from fix/inapp-toast-permission into lotus
CI / Build & Quality Checks (push) Canceled after 0s
Details
CI / Trigger Desktop Build (push) Canceled after 0s
Details
CI / Secret scan (gitleaks) (push) Canceled after 0s
Details
CI / Docker image build & smoke test (push) Canceled after 0s
Details
CI / Playwright smoke (e2e) (push) Canceled after 0s
Details

Browse Source
This commit was merged in pull request #395.
This commit is contained in:
jared
2026-10-18 03:06:12 -04:00
parent 667925733e 3bf040f17a
commit ed24d7f78e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/pages/client/ClientNonUIFeatures.tsx
+8 -2
View File
@@ -336,7 +336,9 @@ function InviteNotifications() {
if (quietActive) return; if (quietActive) return;
if (showNotifications && notificationPermission('granted')) { // [Gitea #324] The in-app toast (focused window) needs no browser
// permission; only the OS notification does.
if (showNotifications && (document.hasFocus() || notificationPermission('granted'))) {
notify(newCount); notify(newCount);
} }
if (notificationSound && inviteSoundId !== 'none') { if (notificationSound && inviteSoundId !== 'none') {
@@ -648,7 +650,11 @@ function MessageNotifications() {
if (quietActive) return; if (quietActive) return;
if (showNotifications && notificationPermission('granted')) { // [Gitea #324] notify() shows an in-app toast while the window is focused,
// which needs no browser permission; only its OS-notification path does.
// Gating both on the permission left people who declined it (most web
// users) with a ping sound and nothing on screen.
if (showNotifications && (document.hasFocus() || notificationPermission('granted'))) {
const avatarMxc = const avatarMxc =
room.getAvatarFallbackMember()?.getMxcAvatarUrl() ?? room.getMxcAvatarUrl(); room.getAvatarFallbackMember()?.getMxcAvatarUrl() ?? room.getMxcAvatarUrl();
notify({ notify({